-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Material remove #613
Material remove #613
Conversation
LGTM |
Why did you do this? This should be reverted because it just strips down the template without benefit. I think it was cool to show off the new material design. It's easy to remove material if we don't want it, but harder to add if we do. |
I like this move, makes the example app much more concise. I just want to understand the reasoning behind this, since even today we had commits in the direction of improving material support. Should I expect this PR to be reverted anytime soon? |
Material is a part of angular for now. I don't understand this PR |
I actually agree with the remove. If you try to actually build a real app you can't with material. It's way too early to use it. |
Ideally what we should move towards is:
Ideally (that's what we're doing at work):
But that takes some effort idd :) |
Hi, can I ask why material was removed? One of the reasons i wanted to use this starter pack is because it had angular 2 and material. Is there another way you suggest I incorporate material back in? What other css framework should we be using if not material? |
mgechev's seed has a an "Examples" section where it shows forked repos that added library X to the seed Perhaps a similar thing is needed for this seed because no seed will suite everyone! |
I believe that's the plan with the material2 branch. If kept in sync with master, that should be enough. |
Yes, please update material2 branch and this will be a fine solution to meet more dev's needs. @jaycangel You can check out the material2 branch when its ready, or simply go to master branch, and look at previous versions of package.json and src/platform/browser/angular2-material2/index.ts That is the most recent commit before material design was removed. |
Hey guys sorry for the lack of explanation about this. Yes the material2 branch will be kept in sync with master. The idea is to keep material separate especially while it is still unstable (while still making improvements and expanding on examples on that branch). @gdi2290 will make an update to the readme about this so people can still use that version if they like. |
👍 Good move, simplicity in mind. |
* Remove material2 and simplify html and css * add form back to home * add exterior state back to app * add about content back in * update e2e test
Remove material2 and all references from starter app
Also update tests and simplify css