Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tslib instead of ts-helpers #1447

Merged
merged 1 commit into from
Jan 31, 2017
Merged

Use tslib instead of ts-helpers #1447

merged 1 commit into from
Jan 31, 2017

Conversation

JoniJnm
Copy link
Contributor

@JoniJnm JoniJnm commented Jan 31, 2017

Typescript 2.1 has a new option called importHelpers that allows use noEmitHelpers without ts-helpers.

In ts-helpers wiki:

NOTE: Starting Typescript 2.1 this package won't be needed anymore

More info:

With this change we can use extends in protractor ts files for e2e tests.

If you don't want do this change, you should add require('ts-helpers'); at the beginning of the file protractor.conf.js.

@katallaxie katallaxie self-requested a review January 31, 2017 17:18
katallaxie
katallaxie approved these changes Jan 31, 2017
View reviewed changes
Copy link
Contributor

@katallaxie katallaxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@katallaxie katallaxie merged commit b3550c3 into PatrickJS:master Jan 31, 2017
awcodify pushed a commit to awcodify/d3-angular-4 that referenced this pull request Aug 28, 2017
@JoniJnm @katallaxie
Use tslib instead of ts-helpers (PatrickJS#1447)
775ab7f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katallaxie katallaxie katallaxie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoniJnm @katallaxie