Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embraces ng2 styleguide *.component.{css|html|ts} #1084

Merged
merged 1 commit into from
Oct 5, 2016
Merged

Embraces ng2 styleguide *.component.{css|html|ts} #1084

merged 1 commit into from
Oct 5, 2016

Conversation

dherges
Copy link
Contributor

@dherges dherges commented Oct 5, 2016

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Embraces angular2 styleguide for naming of component files, see: https://angular.io/styleguide#!#file-structure-conventions

  • What is the current behavior? (You can also link to an open issue here)

*.css, *.html

  • What is the new behavior (if this is a feature change)?

*.component.css, *.component.html

  • Other information:

Copy link
Contributor

@katallaxie katallaxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@katallaxie katallaxie merged commit 039deb5 into PatrickJS:master Oct 5, 2016
@dherges dherges deleted the embrace-ng2-styleguide branch October 5, 2016 09:13
@k-schneider
Copy link

Shouldn't e2e/spec files have been renamed as a part of this effort as well? An example from the linked docs is "heroes.component.spec.ts".

@michaeljota michaeljota mentioned this pull request Oct 15, 2016
awcodify pushed a commit to awcodify/d3-angular-4 that referenced this pull request Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants