Prevent arguments from being interpreted as options #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickF1
approved these changes
Jan 14, 2021
PatrickF1
changed the title
PatrickF1
changed the title
|
Can you link me to documentation that describes how -- fixes it? EDIT: nvm didn't realize this is a POSIX thing which is easy to Google https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap12.html#tag_12_02 is where it's described |
|
Doesn't __fzf_search_shell_variables.fish have the same problem? |
|
It's included. |
|
I really don't see it... |
|
@kidonng Oh LOL I typoed. You probably thought I was crazy. I meant __fzf_search_git_status.fish |
|
Right, I forgot that it will insert paths eventually. |
|
Nice, thanks! I was about to ask why you didn't add |
PatrickF1
pushed a commit
that referenced
this pull request
Mar 6, 2021
) Just like #80, solves an issue introduced in https://github.com/PatrickF1/fzf.fish/pull/119/files#diff-fd01aaa375d8928720283f620b157dd451536fe8ef06d837110f2502b2f1660eR9. This one is when the current token is --option when executing the search files feature.
hrshtst
pushed a commit
to hrshtst/fzf.fish
that referenced
this pull request
Apr 22, 2021
Prevent errors that can happen if the current token, selected path, or selected command, beings with a `-`. Examples where fzf.fish would error: - the cursor is over the token --something when the user executes search files - the cursor is over -z when the user executes search variables - the selected changed path from git status is -folder - the selected command is --function The solution is to delineate the end of options with --, which is a POSIX specification defined in https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap12.html#tag_12_02 (guideline 10), which is respected by Fish builtins. After --, the command will always interpret the arguments as positional arguments.
hrshtst
pushed a commit
to hrshtst/fzf.fish
that referenced
this pull request
Apr 22, 2021
…atrickF1#132) Just like PatrickF1#80, solves an issue introduced in https://github.com/PatrickF1/fzf.fish/pull/119/files#diff-fd01aaa375d8928720283f620b157dd451536fe8ef06d837110f2502b2f1660eR9. This one is when the current token is --option when executing the search files feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User inputs, file names and commands can contain leading hypens (
--), which may cause errors or the function not working.Examples where fzf.fish would error:
The solution is to delineate the end of options with --, which is a POSIX specification defined in https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap12.html#tag_12_02 (guideline 10), which is respected by Fish builtins. After --, the command will always interpret the arguments as positional arguments.