Ensure history uses fish builtin #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I must have accidentally set the execute permission on that file while testing and never noticed it until now.
PatrickF1
reviewed
Dec 7, 2020
| @@ -1,9 +1,9 @@ | |||
| function __fzf_search_history --description "Search command history using fzf. Replace the commandline with the selected command." | |||
| # history merge incorporates history changes from other fish sessions | |||
| history merge | |||
| builtin history merge | |||
There was a problem hiding this comment.
Are you sure we don't want command instead of builtin? Here, we are using the fish provided version of history and command forces us to use that.
There was a problem hiding this comment.
My bad--sorry--you are right. History is a builtin and so we want builtin history. Thanks for your PR!
There was a problem hiding this comment.
Thanks! Here is a reference to the builtin docs in case anyone else comes upon this https://fishshell.com/docs/current/cmds/builtin.html
PatrickF1
approved these changes
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps prevent issues with ctrl+r if
historyis aliased to something else.