Thoroughly document features and improve configuration section #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickF1
force-pushed
the
redo-features-explanations
branch
from
49a251f to
1fdde5d
Compare
PatrickF1
force-pushed
the
redo-features-explanations
branch
from
c49abc3 to
2da081f
Compare
PatrickF1
force-pushed
the
redo-features-explanations
branch
from
12d6858 to
85aecbc
Compare
PatrickF1
force-pushed
the
redo-features-explanations
branch
from
633edf9 to
558d7a2
Compare
PatrickF1
commented
Oct 19, 2020
| @@ -156,7 +183,7 @@ Fzf optionally comes with its own [fish extension][]. It is substantial but `fzf | |||
| [fisher]: https://github.com/jorgebucaran/fisher | |||
| [fzf_default_opts]: https://github.com/junegunn/fzf#environment-variables | |||
| [fzf]: https://github.com/junegunn/fzf | |||
| [git log]: images/git_log.gif | |||
| [git log search]: images/git_log.gif | |||
There was a problem hiding this comment.
Realized all the other gif link names had an action verb at the end so make the git log link name follow suit.
PatrickF1
commented
Oct 19, 2020
| @@ -67,13 +92,15 @@ If you are on certain distribution of Linux, you will need to alias `fdfind` to | |||
|
|
|||
| ### Using custom key bindings | |||
|
|
|||
| Each function is assigned mnemonic key bindings by default (see screenshots above) in [conf.d/fzf.fish][]. However, if you would like to customize them, you can prevent the default key bindings from executing by setting `fzf_fish_custom_keybindings` as a [universal variable][]. You can do this by running | |||
| If you would like to customize the key bindings, first, prevent the default key bindings from executing by setting `fzf_fish_custom_keybindings` as an [universal variable][]. You can do this with | |||
There was a problem hiding this comment.
Now that the key bindings and their mnemonics are more prominent, don't need to reference them; assume the reader is already aware of them.
PatrickF1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve feature explanations by creating a new section and describe the features in a methodical and thorough way, each with their own sub-section.
Additionally, improve explanations of configuration and troubleshooting.