put $fish_key_bindings inside quotes

[uiae]

This commit fixes startup error messages of fzf.fish in case
$fish_key_bindings is not set.
If $fish_key_bindings is not set to a value, fzf.fish would generate the
following error messages on startup:
[: Missing argument at index 2

~/.config/fish/conf.d/fzf.fish (line 12):
if [ $fish_key_bindings = 'fish_vi_key_bindings' ]
^
from sourcing file ~/.config/fish/conf.d/fzf.fish
called on line 294 of file /usr/share/fish/config.fish
from sourcing file /usr/share/fish/config.fish
called during startup

[PatrickF1]

Hi @ uiae, change looks good, but I'm curious--why does your fish environment not have a fish_key_bindings variable set? Anyway, thank you so much for opening up this PR and fixing a bug!

[uiae]

Hi patrickf3139, thank you for merging the PR!

You are right, $fish_key_bindings should be set in normal setups of fish.

I stumbled upon this incident while running fish for the first time on a new machine. I migrated all plugins (including fzf) and config.fish to the new machine but not ~/.config/fish/fish_variables.

$fish_key_bindings is set inside ~/.config/fish/fish_variables. If this file does not exist, fish will create it and set $fish_key_bindings to 'fish_default_key_bindings'. Fish will do this after fzf.fish is loaded. Therefore, fzf.fish is loaded before $fish_key_bindings is set, which generates the above-mentioned error message. All consecutive startups of fish shell and fzf.fish are be fine as ~/.config/fish/fish_variables now exists and $fish_key_bindings is set.

So steps to reproduce are:

• delete ~/.config/fish/fish_variables
• close all running fish shells
• open a fish shell

[PatrickF1]

Ah that makes sense. Good fix! Even if no one ever deletes that file, I think it makes sense to quote the variable anyway! Thank you uiae.