Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define command completions for fzf_configure_bindings #177

Merged
merged 3 commits into from
Jun 16, 2021

Conversation

PatrickF1
Copy link
Owner

No description provided.

@PatrickF1
Copy link
Owner Author

PatrickF1 commented Jun 16, 2021

Todo: consider whether to use two sets of tab completions: 1 for --varariable= (description=change the key sequence for...), 1 for --variable (description=disable the key binding for...).

@PatrickF1 PatrickF1 changed the title Add command completion to fzf_configure_bindings Add command completione to fzf_configure_bindings Jun 16, 2021
@PatrickF1
Copy link
Owner Author

Decided against it:

  • to keep the tab completion menu from getting too packed
  • there are almost no examples of completions that include = at the end of the option in fish's official completions
  • the = completions don't work well, it still adds a space after selecting the option, suggesting to the user that they can include a space after the option even though it's required

@PatrickF1 PatrickF1 changed the title Add command completione to fzf_configure_bindings Define command completions for fzf_configure_bindings Jun 16, 2021
@PatrickF1 PatrickF1 merged commit f2be893 into main Jun 16, 2021
@PatrickF1 PatrickF1 deleted the command-completion branch June 16, 2021 23:18
@PatrickF1 PatrickF1 restored the command-completion branch June 16, 2021 23:18
@PatrickF1 PatrickF1 deleted the command-completion branch June 16, 2021 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant