Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul key bindings mechanism #158

Closed
wants to merge 47 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
f16abc7
start on base function, rename search_current_dir to search_dir
PatrickF1 May 10, 2021
a0a26c3
forgot to bring in fzf_search_vars_cmd
PatrickF1 May 10, 2021
8b40079
undo rename of current dir, do it in next PR
PatrickF1 May 10, 2021
d9dfab5
pre-packaged bindings
PatrickF1 May 10, 2021
79d98ee
no longer need to qualify fzf_search_vars_cmd
PatrickF1 May 10, 2021
1e6c6d8
add uninstaller, set up bindings by default
PatrickF1 May 10, 2021
483be8a
start work on uninstall
PatrickF1 May 10, 2021
3db52f5
fix key binding maps
PatrickF1 May 10, 2021
718bfaf
simplify desc
PatrickF1 May 17, 2021
cf23ea4
fix tests
PatrickF1 May 17, 2021
b88d86f
update uninstaller, add tests for uninstaller
PatrickF1 May 17, 2021
aacb678
start on installer tests
PatrickF1 May 18, 2021
168b4a3
fix key bindings uninstaller
PatrickF1 May 18, 2021
b60375e
specify bindings through flags
PatrickF1 May 18, 2021
3ab9b5a
return 22
PatrickF1 May 19, 2021
a8d5773
uncomment
PatrickF1 May 19, 2021
a09fa06
erase bindings of all modes on uninstall
PatrickF1 May 19, 2021
20a3980
new test
PatrickF1 May 19, 2021
1db5203
erase autoloaded functions, log on uninstall
PatrickF1 May 28, 2021
db5bb0b
add migration message on update
PatrickF1 May 29, 2021
049c1f1
update uninstaller
PatrickF1 May 29, 2021
a0410f7
don't output error message for empty bindings
PatrickF1 May 29, 2021
3a02ae7
add help message
PatrickF1 May 30, 2021
a6c433b
print help if no args
PatrickF1 May 30, 2021
7ff20d4
make help message own func
PatrickF1 May 30, 2021
165adb6
improve install help
PatrickF1 May 30, 2021
ebfcfc6
finalize option entity names
PatrickF1 May 30, 2021
3f26ca9
key bindings -> keymap
PatrickF1 May 30, 2021
64a20b9
use begin/end block
PatrickF1 May 31, 2021
ea1dd8f
fix broken tests
PatrickF1 May 31, 2021
befa579
improve test
PatrickF1 Jun 1, 2021
3769cb1
use for loop to dry up key bindings, uninstall_keymap should be private,
PatrickF1 Jun 1, 2021
ab83155
Merge branch 'main' into key-bind-mechanism
PatrickF1 Jun 1, 2021
f37529a
Merge branch 'main' into key-bind-mechanism
PatrickF1 Jun 2, 2021
9d4d147
fix a test
PatrickF1 Jun 2, 2021
ad44434
thoroughly test happy path for install keymap
PatrickF1 Jun 2, 2021
220444a
amend test for insert mode
PatrickF1 Jun 2, 2021
027cbb7
update migration message
PatrickF1 Jun 2, 2021
70b5864
remove grep from tests
PatrickF1 Jun 2, 2021
60956cf
simplify ignoring stderr from bind
PatrickF1 Jun 2, 2021
68c7f29
start on readme
PatrickF1 Jun 2, 2021
322f580
rename install to configure
PatrickF1 Jun 3, 2021
bd5f33c
build in keymaps into install function
PatrickF1 Jun 3, 2021
e5ab7fa
fix help and merge configure_keymap files
PatrickF1 Jun 3, 2021
992b423
fix bug with --option=
PatrickF1 Jun 3, 2021
528bb48
revamp tests for speed and organization
PatrickF1 Jun 3, 2021
e8d1bf6
shorten code using key_sequence
PatrickF1 Jun 3, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
uncomment
PatrickF1 committed May 28, 2021
commit a8d577316fcb3e4087c6f4e76242938b29f0decd
18 changes: 8 additions & 10 deletions functions/fzf_install_bindings.fish
Original file line number Diff line number Diff line change
@@ -24,15 +24,13 @@ function fzf_install_bindings --argument-names dir git_log git_status command_hi
bind --mode insert $_flag_shell_vars $__fzf_search_vars_command
end

# intentionally omitting __ so that the user can easily find it and use it when they
# are debugging their key bindings
# function fzf_uninstall_bindings \
# --inherit-variable _flag_dir \
# --inherit-variable _flag_git_log \
# --inherit-variable _flag_git_status \
# --inherit-variable _flag_command_history \
# --inherit-variable _flag_shell_vars
function fzf_uninstall_bindings \
--inherit-variable _flag_dir \
--inherit-variable _flag_git_log \
--inherit-variable _flag_git_status \
--inherit-variable _flag_command_history \
--inherit-variable _flag_shell_vars

# bind --erase $_flag_dir $_flag_git_log $_flag_git_status $_flag_command_history $_flag_shell_vars
# end
bind --erase $_flag_dir $_flag_git_log $_flag_git_status $_flag_command_history $_flag_shell_vars
end
end