[Search files] make fd configurable, exclude hidden files by default #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickF1
commented
Feb 16, 2021
| @@ -3,7 +3,7 @@ function __fzf_search_current_dir --description "Search the current directory. R | |||
| # See similar comment in __fzf_search_shell_variables.fish. | |||
| set --local --export SHELL (command --search fish) | |||
|
|
|||
| set fd_arguments --hidden --color=always --exclude=.git | |||
| set fd_opts --color=always $fzf_fd_opts | |||
There was a problem hiding this comment.
renamed the variable because we are using opts everywhere else, e.g. FZF_DEFAULT_OPTS
PatrickF1
commented
Feb 16, 2021
| if test -d functions | ||
| @test "doesn't change fd's base directory if no slash on current token" -z (string match --entire -- "--base-directory" $fd_args) | ||
| test -n "$fd_captured_opts" && test -z (string match --entire -- "--base-directory" $fd_captured_opts) |
There was a problem hiding this comment.
Out of scope: this test wasn't failing even when the code wasn't working.
hrshtst
pushed a commit
to hrshtst/fzf.fish
that referenced
this pull request
Apr 22, 2021
…atrickF1#126) Making fd configurable has been a long time ask and I'm finally giving in (e.g. PatrickF1#107, PatrickF1#112, and many other issues). It makes sense because fd has a wealth of useful options and I can see how others may want to play around with them to fit their use case. I also have decided to exclude hidden files by default. This is a backwards break change but I doubt many people will notice. It was only ever useful for me to search my own dotfiles repo, and much of the feedback I got was asking to NOT search hidden files by default. I also made this change because it makes the new configuration code much simpler to implement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making fd configurable has been a long time ask and I'm finally giving in (e.g. #107, #112, and many other issues). It makes sense because fd has a wealth of useful options and I can see how others may want to play around with them to fit their use case.
I also have decided to exclude hidden files by default. This is a backwards break change but I doubt many people will notice. It was only ever useful for me to search my own dotfiles repo, and much of the feedback I got was asking to NOT search hidden files by default. I also made this change because it makes the new configuration code much simpler to implement.