Expand tilde while searching files #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kidonng
commented
Jan 30, 2021
| @@ -6,11 +6,12 @@ function __fzf_search_current_dir --description "Search the current directory. R | |||
| set fd_arguments --hidden --color=always --exclude=.git | |||
| set fzf_arguments --multi --ansi | |||
| set token (commandline --current-token | string unescape) | |||
| set expanded_token (string replace --regex -- "^~/" $HOME/ $token) | |||
There was a problem hiding this comment.
In fact we can use an unquoted ~ instead of $HOME here, but that would be too confusing 😄
There was a problem hiding this comment.
I personally find string replace --regex -- "^~/" ~/ $token more aesthetically pleasing, but this works too.
jorgebucaran
approved these changes
Jan 30, 2021
|
Nice work! Thanks @kidonng and thanks for helping review @jorgebucaran :) |
PatrickF1
pushed a commit
that referenced
this pull request
Mar 23, 2021
Evolved from #109. Now not only does tilde (~) in the current token get expanded, variables do as well. This is useful for quickly accessing known directory variables, e.g. $XDG_CONFIG_HOME, $TMPDIR, $JAVA_HOME, $fisher_path, $__fish_user_data_dir.
hrshtst
pushed a commit
to hrshtst/fzf.fish
that referenced
this pull request
Apr 22, 2021
Before, vim ~/<ctrl-f> did not work. Users had to manually expand ~ (e.g. vim /Users/aaa/<ctrl-f> worked fine). This is because the test built-in and fd doesn't expand ~ automatically, so we have to expand it ourselves. Fixes PatrickF1#88
hrshtst
pushed a commit
to hrshtst/fzf.fish
that referenced
this pull request
Apr 26, 2021
Evolved from PatrickF1#109. Now not only does tilde (~) in the current token get expanded, variables do as well. This is useful for quickly accessing known directory variables, e.g. $XDG_CONFIG_HOME, $TMPDIR, $JAVA_HOME, $fisher_path, $__fish_user_data_dir.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #88
Fish's
testandfddoesn't expand~automatically, so we need to expand it ourselves.