Skip to content
This repository has been archived by the owner on Jun 16, 2023. It is now read-only.

sync users/keys from OneLogin #3

Merged
merged 5 commits into from
Aug 8, 2019
Merged

sync users/keys from OneLogin #3

merged 5 commits into from
Aug 8, 2019

Conversation

eyablonowitz
Copy link

@eyablonowitz eyablonowitz commented Aug 5, 2019 •
edited
Loading

This PR allows the bastion to sync its users from OneLogin.

Notes:

  • OneLogin credentials are sourced from encrypted keys in SSM Parameter store. Accessed via EC2 instance profile. Credentials are read-only, but worth considering if there are any security concerns with the bastion (and anyone with a shell on it) being able to access them albeit hopefully in a fully audit-able environment.
  • Optionally allows filtering on a list of role IDs
  • Deletes OL non-active users

terrancej
terrancej reviewed Aug 6, 2019
View reviewed changes
main.tf Show resolved Hide resolved
terrancej
terrancej reviewed Aug 6, 2019
View reviewed changes
Copy link

@terrancej terrancej left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending the comment above

terrancej
terrancej reviewed Aug 6, 2019
View reviewed changes
Copy link

@terrancej terrancej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider updating the Usage

trobinsonpp
trobinsonpp reviewed Aug 8, 2019
View reviewed changes
Copy link

@trobinsonpp trobinsonpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on a few minor things

onelogin_sync/onelogin_sync.py Outdated Show resolved Hide resolved
user_data.sh Show resolved Hide resolved
@eyablonowitz eyablonowitz merged commit 03e9658 into pp_master Aug 8, 2019
@PatientPing PatientPing deleted a comment from trobinsonpp Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@terrancej terrancej terrancej left review comments

@trobinsonpp trobinsonpp trobinsonpp approved these changes

@efredrickson-patientping efredrickson-patientping efredrickson-patientping approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eyablonowitz @terrancej @trobinsonpp @efredrickson-patientping