Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix The Light of Meaning adding stats to allocated sockets #8108

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

Paliak
Copy link
Contributor

@Paliak Paliak commented Aug 6, 2024

Fixes #8105

Description of the problem being solved:

Mods from The Light of Meaning applies to jewel sockets causing them to grants the added mods.

Steps taken to verify a working solution:

  • Test build from issue
  • Test jewel in socket granted by voices
  • Test jewel in normal tree large socket

Link to a build that showcases this PR:

eNq1XFmT2siyfh7_CqIj7tM1tvZlwj43xC7QBgIkeCG0lBbQhjYkfv0tCXqZHtOm3X1mItqSKvOrzKyqrKxUoh__V4VBpwRp5sfRzwf0G_LQAZEV237k_nxYLUdd5uH__vPlh2Lknuz0Cj9oWv7z5a8f7XUnACUIfj4w-EMnN1IX5OtHKHwHoRIjyj0QR6Kxj9NxbP98WHqgl_oRmEGYh45pRLaf_3yQ4gg8dKzAyDLJCMHPB9WCIA8dI7NAZPefn3PtA4gKqT0jNawcpEIjA1fksRjbkMQxggyChYYfqbF1APk4jYsE6vbQKX1wuhDxoiIvli8E9KOrgGMjLQ6eET1AJf_6oQRGDVI1N_JOBv9AAaCtDBdMfChBaQQFxEIevr9J2yvSLB8YIbz8PY-aAGD_nkxJwdBxgJX7Jeinft6HElt3wL-XViyC3E8CH6RP9Og38hbH5F_gKHITfhnnRjBQ1N8LcqGM77C45udeL4AWvAu3oebdyM_B3eRK7Gdx9C6p7yLuF0EAV8RdtAuQgbQ0cv9OQfpxaMIVZ99JHAd2fIpeDDdCUjdneAoM2bnMxIVh-0UmgjwF2RM3-Y2-xSsakdGPsztGtaFUQApXfv4uBhVYMfQe7-3jnZyC74D7Kd-lx5XhvdL8mR5D9V66dwP_mUAL6DDvo1TjIriTMn92ZPgbK-z4khAlb3q8AaieyJi38F4S0tgtQj561oEg34B7SUgit6Ur47zdSO9yVsOJ8sJxE-Q3HENQlkYIAr-5D3l15ltGIBqVHxYh3ACWxgG88B4Ihd6eqq6XR9Dr3WKmqJv9jvwU3GKjCfq2dwvsP2HzjDi7xccwxFuL8S5TwF3f-ruh5iPrvjW-itJ2G3gRLLxtawcs4NprIhIzAHfzPHdzXcP37OyXzlwQXXusn2387U1bCQBY3hgGbgsjB_f57OdVQBJvWrchvsu6DeEvrIvR9H0crw1FvtnTr-3Evr1tvtNOwwikbq16Pgjs91E_CtY3krtCV-vvl9x3mfuf3f3KGHexvtMkmpHa9-1A75WpNLKXHhel3zbXhfy-iQlgZAsZbHBvBK-k8b45IwTvY-PSMC7SOwf8QnyXAo-bxeUstAB2Yd23Oz0ddXoBPNHdq8YTF5QzCN7FyuW5YR0Gse3ebbS2k3dx_FM-tUgS6EKa2XAvQLMJwsOA_yLw6RLY76llOJXvWtHNdnl_B8_Ud3fwFAK87oW6l-V-XZo9_HU32D3kd3fxNKAidBYh3APaw7wYv9iibw4OPP_ddT5rCe88VCrxCUruNXmZ7H3UMNZ5DpNvipKC6Fzfjf8P8rs6GEZ2kTZL4e4-XnP8qpulH0JHmmUDIzc69jVCXhupb0Q51qaJMmCklifAoR8ZQWBCT_Dz4eXT9q5NLY38IAfpAD5rOm0Ee42IPg76j-9txqy54sMkTvOO3_4j-BGEB9IR1SX0TOxd1SFpZqRSR7oIeEawpVl-yOcpRXjzw6DWlqWeGkNhxdGncJvJiwijSho3kGgscxVGT327h01NfMmiOavm66wAPsru0tm-do_yxhNHgXrOl9oplkuJi05gVrPOggDdI-aUeECOZyKmTD0nWc3rIO_KToDwBrH2A-ZUajW5OOTebJS4bLQSts6ptxpnq6y_kt1qQonEuZiX3Zo198N1NZwyY4ZD0Gk4U7hpgVXswFWs1b6eEaV71oqJgObzwWFq9DcuM3GiHV72LcD1k7mAjocKb-z5LfACuncaKQknHiykl3JrPhsirEB6tgdG9SJBjPpQ9gR2FmejeDfokWcu4N1gycnVPMDJTWzwYzWq6fFojJ6kscbPlhPG5XrujF5y7Gl-AMMhwqk1iqphUK6OfjjC9qN13T2fJXvTrXfLsyEzIsrs9-hYj7gdfzwpwyhbE3Kp7j1hVk9jdTLWESwJ1tVkshvSECLjd557XlC7CeKshoftet8jsu5QMJhYEzhVOFpA4IS-NdZraBBfnLmBreq-c-ATMJwHmBvKlqP2x7NDrA5Y62wN9js-HfKOPkBrDsdnSTBi6FN_Jk-KbT0ddtXltEd6o2JIELQpR30BwiRzhTil-_4xmsgir0x3603i-QKxjFcmUMKkGoiZs55pZXJYCqsAbPcgr8QjK6x7JbWZ90Q-lFZxgo36M3RW62rvrO7PGSDJeXaK9_he7x62Y3Kre-T8YJW8dxrKFSoeT_NiiflJZc9Yb3jKkqnWRy2clWfgvCGR7Tq3VdOQ0pFPDmoEFZXhYkJx9naqFvyO2MVjhhgNTlwcHUNhOs9cqreqDRYtho6Y-05v0lXiOb6khzmy8HRRjUOCXJAxQ1q0N64toYx05TgHg5w89JPozIwOa3dmucFAm3et7VzoVrSsji1tDXTTTiaktdU1PVLR00ExiHobkct-uR-HQiYAxgVk5nrHbEQnSKqNjcRZBhWeUsGRc8TjOZelDcmqaBgoCwRbCzZDG1WSkBm3IErJHh5OLMgX5klPY1wLdtKKPuOSLpaOSbvENq6m6XIrMjHjl7l7XgfgMKqc8HTEyoBMhANYlYnnSITXH-96c8JZM_i-QifElGUSZJJkpeaup2k-QqStYG8HK3S93KReUi_Py55TzFjNWM1SaG1gEDEt18dZMq1co79CQyEXNwZjssArKS-T8tFU2FA4c8CW7OLo96fMfD2fEBvXN7lkKrhDQtrp-LFH7qVgWxspma5l1lusu4Rbn7QjSwuTVYDoZSKUtqZsRoabsmRfIk_7fjVPNM4cRxNC73YrhRmlRi8wt4kLHSYe8VYZCwcVpYAP7TRnZucMHXuz3lDe5cmqitiBfgwHIdNT-IKYBk65Ic_71VmVtnNVlQisHB7kWeQ7U33UG67EEbrysRmctAzpzca7xXYp872elZdTpdpisSghah31kIHFEglan5zVIpe7rj5ZwzWDggG6PIrhUBhG9XDKTegpNoi7NL7UCK3CFrEgO05XsJ04wBwVlARr9A-risIDEHLLbJKthbrHWWfHoOvJ7JQGRyAn3dRiuifHFhHciSwRX0t0PdWlLlDtDb_QrSHHdte5g2a7A-pjhB2fN0L_tN27FCei0p7Dhia_CIuwpKMCN6n8nOfeknFPGbPwJqY5y_P5Xql6PVUZz4OhPRf8KbXKt2Ys6njZ7Z8daVPtVblfLmJnZfR2hLkXLX5zWucxNZmk6nbss0w8IzkDDXaJfhqcdQTBdeiV5dRIdl1WyvSB61dDcZ5w4xQ6eJEtsMQOZA23pDmG0Puc1gRpVWGumVlMjW3W_hFjDSoMQ2xpO2scjnVopAvJxQeZVIyPZHqqJussPyGwoeyZKEAx0lzQIMm1k80tdXtVamicu7m4D-NBOR1I2QjVOZwfwBMGh8lwLeSDTVBIfbIyy4Vgi2NmsRyYUo5tk8Dt9-z4VHLHI9FL8tUImQ-25FZWTJKFgx2y6HLlbsbWOM-KtY6v0tTwai7QNoytjBBsHgt7Mt-yaUp1y-04HQWyaO34oUgwzHS9PaGiyPUjZmn3KTWc0M7SxVnNt88a4SR0d6gbS5ooF-eVVKO0XcD9SMiVqDIlsbcz0F1RemJRJkdZ0Mog6-536F4-nqXdJMcNHaMZUnME9TzHdwpV7yI4vUMnUwiWKKcRc054TysXVFb1JTNDBV5bRLOuNhLkwXhVLJFlfDqiSLApqNXcC2y_HClKryQY7KQpWDXu-XATKTM5OkS9oZI7RAXAfLOaCBOMLIXj1uouXEsZT3HQWzumOtDwkj9YVNcNDqS23OOjJWfIisgGPrKaku7Ia_a9CGenw75u2eySQahxlnC2l4sphpy4UZmJZ-jBiWIUnbv2yRyEa2FP86v9BOC2ukzEWcD1yzG-TObd0VSv8AN9VI5TIMjz0F1Zy2yMzYWDvI1RHiFooYpP4661U3E5WyEkd6gFcTZD83RyNlPW5iZqYlS4ND15x6I7T-wNFY55z8PHw7HDe9PIGoszsvLqUhvq3kkC5r7uy6Q_Cy05QvxtmBa7qJQr-YCaNKahIcUOV6ZppHIU8f5ZjGt3vThK08kJO-t-6VB2EJ1HhoeMlhiWBnmGhiOWZUQycrfKVtJoOTxLA3qgd_XKtGybp4rUr2AIo3AKtajKaO1QsCVJ7e5WXAdTIo1JZz_ToW2HNA-QPa5D902lRVAi-FmvkK4cBGRf74kLXdzGjh9YyzUnupHe70lJYCBrnybYrZjszvMzO_cOuq8pSsiWRrg77wmQyKEbHbTY4Zy5OTMYVSy7OtCzYbfCZoejtZwJJFgHVF32UmQ2N2iOiJcj3Q9myD4aa1jsutEwkV2DGS7XA_vQrRlmMND2R25Dgc1k73NL7VwNSi9e6H1PR0tKXgnTge5OvKMuLsb7bjg7GWq3e-guke3IM0xuVfBi3vNHEwRuIJloqrjrUSsDyWSAsAtUEAVCPKHzwOoKlb5yyIMijTR0tsZE_bwRFd9cpWO5RmBMJ_MWw_icFGzO_bMibQoCYTfqkUiW6HCW1vnWZ8Myi1dwi9TEykJNpH-SqlnEbKaGeJw7sdULZ6rLKkhfXtEsM1uUxpDg68PYGfeEyUw3A3V2GFpqLKzChEAWhyDt-RJDLgLJm0XDzUrjfXxkKjM5KnoD2OO0N2NnS0QfDxbK6nQKVNoYuUYtrtfbql9gehAvZp7fz73K2Oi0oY3HI3NY03MFQwprwS8cPCt5ZxRo5oDTHZOvXX5sTmXjRHjGFpc3OwBnNLMwMaXqzqpzmQvaZrc5LKJ4bs2n40StV3M6WEpDwSulFYwfJGSi1gKz2Qymjm_UBImtyLq3rQDhwoAFhUoePPOk8IxXE4SzXSx15MSe_N1B7O6H4wHirty4jqoBuRmiGCeuC94cGeOhxluDekXRWuDVs2UdGxo6pMAg6ev5djDlDvRp0NMi0jn4qDZn4mO3tDYrh1C1IYwrHBqZHoZLcUIUoVEtiPHOm7h0QAl5dYS70kHUuJmRrtHdmciog8TRZ2PCccegKPyMxde-yZ9wDASoYyU-vpfIGXPSFZyGbn2zJU3bXqEDicIKMttHxjKQVCSPDxPWGVb7kSrWXdPoWoziCOgxLMYaMLZGGG7XxwJGIDrWNZAiA2XWnQJxfVIJeo7wcoy5vqQfCjHOvCqqZUHqTUxgTuRCmSDAmYSUrAfW5qBZhh95ei_wKq6LL7PNwl87Ljula2FXzygrWM4FItJ6gRXVxVleGdADF-MNNhiwobkR-2eBPZ8dGz9n5_rsRHq0QZa1yxSGlmLRuQDyMYiltTkNMeWcLTgY10ZqUdjq1CEGue7t6yyan6f9ZIrp2MQrjJl9Eg1-6DIWta4WS8aolWN9mK55dTadrrk1OtjOh72wjnaSwvRSPiYUVDqYmTbY23vlhJGMG_OjtS90AQuPjVSlaUdbNOiFlWVVWPLJ1pSOeG9FGGIwnE-yLpjCebPoqsUupmEkrQN0k65NLfT88UgHRilantavap_FVEMernVVS9fr3qm3zLNuue7O9Ayf0wNVMzRptSZOIjVjJT2XCL1STvyKk_ZJz6Om8_NCUrgeP8gsYmbVWn325E3CHIru0V_iGc_uB0rMs0q8qOApKo_DyXJFAmarixNxsZYA29P3fXmzHnQ1GaQii2ciNe-mW4kz0pDBgwMU3e4TalfasCmQxV6I8Dtft905eZ7GZ2LtVhrWpUASTMTxYDmyTlSw18QkN-fjc4Io8wmzV6epekDDRKzo0OcsO5JTcTNl0_FkvffWFeXWZTRNJVpzscmhTOWpfNyXM3a94isZmVoST8z1uB4vwwNGSgAufEZJyUyKqXJ7UJh9d70d-Ci0DL5fL0eAYZQVhiCIg1oJ0mccSxmZBzmPASHKdLVIGCJEvFKfWAix29uIbXoxVeXn1S4JJJs42wrPU6t67Us9Lew6eYLGSLSkFOns0YI1tdmEMNYyKcvJbCJ2Nygh7cerfC3N95WRFZslF_nneViTBSL5EZHV1ownzj6uZER3Nd3uEk3fbXaIXe9mpRJsSlTphzrBll1FLI9TpYCuAejuduWxk5m6C1kwQIydkxvw7H1M6cFBYbuOlQcjRxIDbIDM9F00Vehku6X7Sk52o0TYI1V9TvpZCeOJBERo5cBjlgg1O-VmLp62Os2mI2Uw2g6V-DRC7C0_ZYg9lbl4ndLslN11eWJPc2XQLWspVcOQqWqe3dAcZge4lPeL3ZZSKcvu8Ybmr5PamY4KvDYMSumf5jbdtfTJEtvR8mx3kpDpiHceOoGR5ZxlxUWUT4zM-_nA0ihlswZJAwwhLcRxEMfCKZsgCMZxLAJDYezMYMSVdQGMIPz5oPQvt_3HYqcLFjywUSZkIAGK0xgEcggAcCiPYZgYQ9kWZVOIw7APHVA1SSbFSPP6sTSqzUa1Tzo2yHI_aktJfj5wQfDQUb34xNllk85axnGQPdVTGQk0rP0PjGUKQMd4TGFbTaarzbA1N50QSg3S-pITzZqU2YtiLt5uE21RDAX4-UDiLIt9JUkWob7iKMXgX3GKYVD4BKfxryTDYPRXnKRJ4iuOkwjzlSAJBP9KYCQB6RmEgE8gDfxLIxT2lcBxnGq4cMhLoST-laYxiEuyzFcUojNNKq-pQjDSmvunSJEPLZBDrV5UsWHktTCtIUBaBf_6sVoI7cVfXp4n2d_fv59Op2-JkXuxAyo_AN-sOPyeQCZomm528IOg28B-5-B_PZfrDW0hxsIpfSK5BTbEg5oQDtm6CMVEdcu0xtFjwGPoYdCb5IVguJDr58-24--PPf-41LZlFzGud61BGzlbKz50_ByEramvuU_I_5LtR5PZTn04BpfM6Pdm4NpUZTOyzYUU56ClbR4-3vxQG4WyTgYn1hiEWa8eKOqoeQn3qtboOjUaahXkl9TqS56fD3lagCZl6hhF0DyfF0bgNzMVeflUuBQZRnEaPlUaQCg4U5uXJhfEZZ00U4kThEsLF-RXsKa7x2l7mZ5XgTq-_Thlrw_bokHuWeq-EVhZK7cfWUEBbRtdE_VPyyIwzEa2pmqyebFuP-qUBXHzAtGP3A768Br3qdu_fkDprqzjIDaNAHtGvmiNQVO4l2EUQW7YRm585-G4Zt8bxb63ePBKacaxyXW3WeeG-vqknX0v7o8vTHy9bloHF2s__EMY9FGbV8q1Xu2ygo3wuvYv8E_TrOn1v2lZGLclcfRR26Jv2_ZpdjXFCfnlFdCTfa-tT01Phn7d8N-y-GMH3z9d3UuVluZH9q80ftn6WumXbU96Y5-s-KWTTtvL5yvfS4u8lfVXur9ofK36i6b_mubPffxroV0voV9rPfjFRzeX7VJrKfgoKfIW7edD6GfWziwcp6mHhsrkaVvxPRyNhv0lvx5eX5a9ZGkV3kVFaDbVwJd_n19pqqB9md_JCjO7XP58WPvg1AoygBb3g6xRKgiMJANPgUTrhK-SB5DvDbSWauI_lVL_GuuZ4DbSsAIpjHtczUit1Ac35Xpq_41Qlw6bCpHm5eIttKaC-TbQpeSg34R-bQXLDUu15eG3UZqa7ZvqNI1v8PJhYgQ3e762_sYSebMNw6nqO77VvJd9e8ibTftC9YZdLKuAoW_9xnhf6yVuY7Ql4bcALo23mS8l37e4r61vWLUtML9p1UvrbfYBsIybul8abzM_FUXFUfuDhV-jPFG9gSTFUTvJ4aLh_KCpbbg5ssMAPJHcBpRzD6TXw8EtJBH6qEeSNxdO6ptFfnsZv6B4w1ZtreYNCzVtt1kvdYg3dGja3vBE_yjNu2HQlzS3oS4lbTcd2VuslzqXm_a7Vs28MQTXgrEb5r-0vmGEx5q5G_pfm99YJK3_5crYty-VUzeWyyuytxwGPCZ9HKYtB_s4zOv6sI8jjuCB9nBzvK-tt9lXud8EIb9AuYQud4E0i-pjCM3a-hjCEp4-8iIFfwyweB2JPPMu3o5Bnmqafsn82PqW57iWOv0xwqUg64_Z23qxP-Zu_T-MhwHU4M0N4InmjfWRF9EAGiN_Y23cCdWK9WtH8qzdu7AuW-EvNX034mWBX39-8JYPuJD8Bgju5ZM3osX7kJ5qHifACJrfx8XBxwD_9TOLj4A1ddtFYkT2I5z8qxj9eRzutF6cZxCzrecbNOXhH7VhBML6F0C35frx_fFU1yZhm3PWtT5RzdMmZ3KO43Dz86GLUt8IhiUojKBYFCcvDdd8GnXNocEAfODDYUzb6ffYbUOoQwQcx76hJPyfwWj08kPAH-25-Zrea66fsnu34YoMXHMDbeKm5XiRk2tQLvk4_JK9WcCjd17_3VlJ_Hw1_LL0QKet_O3ETkcERlMA_EVJ_SyEq97qTMEJBF9WkX8sQIcf_N0xHWBQqG3jNA5wyjIBjpOkbVm2TdvANkmbMS1AoxakshzSRlHHoRmEpAECSIKyzS-tQK2h_u4w5JfLjxv_7giNX_si-CGM2u1OHv_dQb_Ak1HgW3Al_d1BviiXpG_nmiP1o86FtQN1jTsu9Nh553-J_4GsnbbEuHMJrhpv0x7o4XF8YUQu6KTN358PyDfy4ZqovCZpG8mebNakMW-b9p8ZziDO24ywYq4WQjNJLsf6cQAPrtlzshh5zC3cYnhOvd3N0ovhkulwZp1lRtC5JqvJ9wCAIH_Nj93Ff5mlj9PwgtZu6x38D3TuqCcjeS0I8SdAHzDGFQP7BIxfK0R9gkLUJyj0Rxi_UuiXc7Vt4m2I8vq9yQWxdSqdF69SHnv8k8mOf4JJsc8yx3sm7ATAACa_y6DvWLvUhyXA3o3w4S7xz7I_-QmTAf2E9YV-ghzEO2fCZ_ko7KPbD_EJBvzoFvRpHhv_qDWwDy7o9wlg151LVugjM_ISuHwE4dfLnPwwAvVZw4p-lsd5z_BepubH7Uh8eCzJz5lU71GeC4sA5J_gF_FPcC_4Bxcl8UF-9HPs_8f75ge9K_FB_j-Jtz5ocfKjfvyThoz4LMfzaSH8H5_W3sHXlutgH3Zb2OeMwaftIp9xtiT-TKf3Gv_j-_8nBSLkhwX5-PZHvdcZfNR5_LvDS7rpUlTS5BoNG6htnlEDTTYuuyQj23xgW2sSR47vXl3q5eaaG2z5n550cj8PwIuCmJeJqpc1J68_IPhcqfKPDwl-f4Pz-mW_Z86nL_xduZTAsIAXBzZIr7ygSchev8T3WOdCI8hvGF5-W--Ri7zNo3rQ6GpT9JH9q5rmZh___ITGCz6UJt7oyorb1PD7-mr0ed0P_jsjPC77JwYGY6nbPJnv-oHstO-SoHztC7E75AufPkvYfJQPpMBules3JVMqCJwXIORvBH56-fw00Az1OyWvHzCJg6DN1b6cJI_L5mmqX7L17d1_vvz4_vpDmv8PHt4DCA==

@Paliak Paliak added the bug: behaviour Behavioral differences label Aug 6, 2024
@LocalIdentity LocalIdentity changed the title Fix the light of meaning applying to sockets Fix The Light of Meaning granting stats for allocated sockets Aug 6, 2024
@LocalIdentity LocalIdentity changed the title Fix The Light of Meaning granting stats for allocated sockets Fix The Light of Meaning adding stats to allocated sockets Aug 6, 2024
@LocalIdentity LocalIdentity merged commit a037b9b into PathOfBuildingCommunity:dev Aug 6, 2024
2 checks passed
@Paliak Paliak deleted the issue-8105 branch August 6, 2024 04:52
@LocalIdentity LocalIdentity linked an issue Aug 6, 2024 that may be closed by this pull request
3 tasks
@7ekken
Copy link

7ekken commented Aug 9, 2024

When socketed in Scion wheel, the jewel added stat is still calculating the socket the jewel is socketed in. Other sockets that are allocated are not counted as expected behavior. Chaos resistance for example is still +4 over with a new PoB.

@Paliak
Copy link
Contributor Author

Paliak commented Aug 9, 2024

When socketed in Scion wheel, the jewel added stat is still calculating the socket the jewel is socketed in. Other sockets that are allocated are not counted as expected behavior. Chaos resistance for example is still +4 over with a new PoB.

Are you running the dev branch? This patch is not in a release version yet.

@7ekken
Copy link

7ekken commented Aug 9, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: behaviour Behavioral differences
Projects
None yet
3 participants