Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement trigger from the Svalinn unique #8000

Merged
merged 5 commits into from
Jul 28, 2024

Conversation

Paliak
Copy link
Contributor

@Paliak Paliak commented Jul 28, 2024

Description of the problem being solved:

Implements trigger mod found on the Svalinn Girded Tower Shield

Main thing about this pr is the removal of triggered by check in calcLib.canGrantedEffectSupportActiveSkill. This was an initial approach at preventing already triggered skills from being affected by other triggers. This should now not be needed.

Output from build diff test suite: Paliak#11

I've had to include the mod cache to make tests pass. Would be best to regenerate it after merge nevertheless.

Link to a build that showcases this PR:

eNqtW-tz4jgS_zz8FS6qtuqu9gKYVx6VzBYhz9pkkgUye_dpSrEFaEe2GFtOwl7d_37dkg2GQcbGTqoSG_WvX5Ja3W1z_tuHx603GoRM-Bd1u9GqW9R3hMv82UX9ZXJzdFL_7XPt_JnI-dP0MmIcRz7XPp2ra4vTN8oBV7ckCWZUfk04db4BpwXx5ZwK_5H8JYJb4V7Uvwif1q1X4rtMJncOJ2H4hXj0oj52AFy3SOhQ3x2uP48J5yQgjqTBA0odRFI8ChdGZRDBqEeYPxbOdypvAxEtlFJvjL5rmvvH56fRJKUS89MqgUWfzp85WdJgLIm0QvhzUR-AY8iM3jEJrAiPgI_dOe00eqf1ZibiMgpCeUU8uMyLHC8odVfEncbxSauT_JowzwG9nk6pI9kbHQZMDufEd9YS-yZcUdrHiEu24IwGa2saPRPi7ifmdqtlIp4ISfjV83hF22v3Txr2abuXjRDrKTHy_pPJ-SUHtxbij6j7mc8kLQx7FiwU_kHWpEFGg4YR57D9ctGOaEiDNyLZpkJm3sJ7ZX5BXz0SnwxFuJ6LdieL9JkGsLHlBqK1BzCmjoBYkIac9Bun3f6p_j3OIXA3G6PkBzal-SkLGRUDimpzmB3X47x0hRkfptAI4mE-yrGIeE5KuQ5K7Yzd8CNNaJvj8BX9yMHv3pf5pKYJ7V7PLPVNSHX27bNXBYzru-c1V7tlN0567dMeHBWttvGsmC9D5hD-SD6YF3kQpCfkO10L7HROzStwNpc-BB4T1u4asTcsoAfAhoK7h8DmRIQH4HCPreiOexlntHOGtPe-k2_jvviBisOpo93MHgEj2E6YQ7xymhOxFhFvyjzHrhY1o34sb5nPnAdKnfktJFojImm-EL4-TFqZbkXaXG5Fwh1u7eUEFHASAg1OapxmgQq66dqnwWw5njPK3WLUiWJDssgRKdHNaXQud2-KK7Ri0tCCLvmTBGtX2P1O1olSVKs3EqYjrd3Pdpgmz7c0KWSbAHDpVgLcMmfw4i_M33kx2CDwRLQ-zo7bdqYNmjyXCckxoYuXEXUjZ-NcOjX7NalELjlUYVuWdFuNY3svEpTlfBe83W10jPCBlMT5fiXcWW7_KUGFEJs6jqPFAgIKLoy8DPAghJycpXKao34O6idY1bm2Nx6Z-QWsqXMLWKUB-aVsQfLbgud4AWPW5LlFrCb0EeKGByeCKsAfhZsO8sbi4gYqsVxllSLMWd49i3dQfo6NlLAYNaQ860TOqEpA_b-XuflvkOcScO27UYC7IbeMbcQuMRPmQVgNwysiieXGefJXEjDiy7bq8oSUBM78AWb_hnD-CsHgop7-FO-2gDYCkf95UzWy8OreW4hAWvQD_z2TQC4v6lPCQ6oJ1SfAJ5TMV2U1RB7O69Z4Lt4H7htaMRGChwnIIosF9d0NHpOAUoskccRBJZSNeGN5JJRwgumFGaLSqT7YvYtutHwBCkCyc3LS6aCJWHuRYDnYJPQZ6CVBVqodB0W87rRpTij20_nL6EFdfJpLuQjPms339_fGgsi5mNIPOJQajvCaCwCBwkfhd8b5EbJtDuDncjZQP4pRM-F0rltwYVPf4XYMGOis57KJhiqvoyfw4ouQNMQx_DC5OR-jqNAKYSJuqRdeLmH_3GAasdWniF2J1GMq9WJIY5LeoEunJOL4-R8R4QxntpX-9EG3MX0ReKsKCVjBzGKk1xwnywW6fvDwoEcGXMbMUFwyzXo6Y4Us5iZTHH-oupSDtdZDwp1Q6c18h0cuVBZxaIlnkZNX1Ay7slgTuIlFIReYJlGyEL7Vrm_zXYn9dA7axeBbLl4Jbycs4t4tlK_WjHq4LB6pJC5ss-a9BJOaaFdTsYOrQaCyB7V7kFbdqyWxuvuR8m18jWNX2s31DS3sRIstuxwR-XoifeLFmwSZx-tJqxOvpdjLaj3pFYOXyqWK4t5fRFLxuah7LHS-vUbTKbaDQXEZqA739c3N9XBy__U6DjZpiDLumx95r9j31P-TsAHTSVViZIXRa6gvL-pfGX1XilyBIxkP0RzOySKkqzCglkSsOQdcBjdFBVVs0kfezWtNYOZ0_UEDiFozyKqdgFGjXqvxPUppgZhvY3A2ccMerZmRztqGEPN0RWDwlOqKm7lgd9poDg5mYCHeE26UHI_u8YTEoACLlE2Zg-da9pRjCNFUGX5xHDgSnWXGfMcpp5mHanqbGOhBM1g3sU3oeDTDq6p1bvSqHjXDr6hDjLbrQTN4VWQKXz2z2c1lRZXB6Yvw1SKHTTNgHNND48xec7oiMTN8knMaxEe7idMjxKiEJHPjBOw1kuZtnKLI8JVqeRk8hGNmqG7rGGzAsYxItNHqMDg0TWNmpVsExkCWBdWlgtF_ceGRMQVx-W1wvx7NcELSgTDYHw9nbBIVfwdvgrm6-DRsly2yrIABWVt5NqqiLs9mu8Quz_EGEt_vxvmOR83wF8kwmdnBRSctuZjgpirHAfdWOQ4TyDJlFNCDGYy2M5E1dpSdg6xqwp3gZDQrcsSl4sEcdEF7MFzV2wejVfyHTJiCBZkHwIomY3_IyL8CZ8iMvZGTlVJrdyBZW1eIlz4Kd1pamKPe4PFTnKwYoEn2MIKz_C4jW8zHadU2uqOE4xN_wcsx_OlpVRlm2AWPFsR3E3ZPu3L09Tzk9J6QIfBUjZIrbLaX9aFPveUORma9zptJVadaKFhnxf2dsQywOv5bCO8_qvDEq7ic78QlPGTcVwzmLVDrLZGDhP9OelPnquKN-wl4vWonmBlEIdUPv3UVrhBYs-tCEniky_8RVM5yeWa9fLn_4-W6Nn6D8tj3rVsWuNStDQUXYUi4NcEgY-ncp6YTiTPruG3H15ckTN4FYJyeWXYNMx343--oq5_HHyiZRXAF2klOg9ASU-t3wmdRFNTi9sWZ1W7V4rbNmTU6gt-a8uCI_jizeq0alEKcOQxH7dp_IQjP6Fmr0fvfr_-wW0ft1j8tKSxPL2MLT7ma3fnF0kUKDqnkwlKHuqUntvar3enjEOpcO7Jbv6RZbCN1pZhA91FvyIkHJ8kgC62HyPm-rE0CNpuBp4mlDaeuBXk8Ri6YBM0CFq0C_ct6Z3IOlK1Gu2fpGbeGsO9d8e6rpsSjcEfoFEu5BhvHvXo893HbwkjR3kvR2UvR3UvR20vR30uRtMJVb2i1xLHJZdoHm90vLqQFpZ_3_PoyesAtq5sst1y84TGBQ7oz2cwGxC0vuwDkUkAAswavS7XF9IRbvSIMKJfb-HYBvEqrrM4BVlrjd7LYFt09hFEJ85MuYwU8dhvUr8CgfgUGHcRjl0GlV2enAo-0q7KmyHq7o5D_yVL-2LHZ-qU1aBfmUFpkpyr_9ypYDHYF28OuQI9uwZVQVYhpl92R3QocWPzMqCzEdsra3y65hYsp4C4tnfGWWYM6tyjDYffG7pXm0K9qWu2qYkzxpVnej93Sc9mrZlEVMX7gRZzKCiJhp4KA0im5Kbsl8XY1_j_4pCy8aLuFEYdkUWuIfYhXe2VjdUXT0q0quFSWVx9cQhXAjZg_KzTru0NTu5o5qOykqKLg6x5mU1Hnlz_jK0o2eqUVKX_E9YsGg7LB42eBuueTvGmjOqXqRRvhT9ks7pnqm7hrqkCrTzb6QM-cOHQuuEuDWAmK3eD424_JSzbHrZXuBkD6K4wJqmfGjOdg3Bj7iOFPr_IYZSSrd0XfzhDgCNWNLiYBrUhe70kwnQzTvdUXMfHrhjSgrpI4xJemxpRPU5J7e0Rvvuidcv0eXPxiuOBc9QnTc7YHuXrsnSD6GbJCNmP8aaoeuoGN6snh9itYzdUS048I1N3n2nlz-9vK_wedDWPD

@Paliak Paliak added the enhancement New feature, calculation, or mod label Jul 28, 2024
@LocalIdentity LocalIdentity merged commit e640c41 into PathOfBuildingCommunity:dev Jul 28, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants