Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where empty configs were not loaded properly #7996

Merged
merged 2 commits into from
Jul 28, 2024
Merged

Fix issue where empty configs were not loaded properly #7996

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fdfd069
fix #7984: Empty configs were not considered
Wires77 Jul 28, 2024
3ff5f7a
Revert undefined behaviour
Wires77 Jul 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Classes/ConfigTab.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -655,6 +655,11 @@ function ConfigTabClass:Load(xml, fileName)
end
end
end

-- Catch special case of empty Config
if xml.empty then
self:NewConfigSet(1, "Default")
end
for index, node in ipairs(xml) do
if node.elem ~= "ConfigSet" then
if not self.configSets[1] then
Expand Down
Loading