-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DoT Multi when using Maligaro's Virtuosity and Perfect Agony #7965
Merged
LocalIdentity
merged 6 commits into
PathOfBuildingCommunity:dev
from
DieMango:PerfectAgony-Crit-Override-fix
Jul 28, 2024
Merged
Fix DoT Multi when using Maligaro's Virtuosity and Perfect Agony #7965
LocalIdentity
merged 6 commits into
PathOfBuildingCommunity:dev
from
DieMango:PerfectAgony-Crit-Override-fix
Jul 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalIdentity
approved these changes
Jul 28, 2024
LocalIdentity
changed the title
Perfect agony crit override fix
Fix DoT Multi when using Maligaro's Virtuosity and Perfect Agony
Jul 28, 2024
G'morning, I'm not sure if this issue is related to what I'm getting in the latest PoB beta There is a massive difference in my poison damage, which isn't "realistic" (I know poison dmg is a complex thing, but this is is just unreal) Here's the build code:
|
@NokTham Poison Stacks were applied twice to Poison DPS. Will be fixed in the next hotfix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7961 .
Description of the problem being solved:
reduced CritMult Override value in Perfect Agony section of CalcOffence.lua by -100
Added a Minimum of 150% to CritMult to DoTMult conversion (Maybe possible to test with -Crit mult on Kalandra mirrored rings)
example:
400% -> 300%
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/AzY-pbIZf4HU
Before screenshot:
After screenshot: