Fixed monster explosion ignite divide by 0 calculation error #7954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7912.
Description of the problem being solved:
There are some divisible-by-0 calculation errors for monster explosions (such as chieftain, occultist, and gladiator ascendency). The "On Kill Monster Explosion" skill seems to have a cast time of 0, and causes some stats to be
nanorinf.When the ignite duration is 0 seconds, the ignite DPS becomes
inf, thus reaching dot cap.I'm worried that the 0 cast speed for monster explosions would cause any other existing or future issues, but here's the bandage fix for the ignite problem caused by it.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/dbGiJENwcvZX
Before screenshot:
After screenshot: