Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Non-Instant Life Leech with Strength of Blood #7937

Conversation

greatnameincoming
Copy link
Contributor

Fixes # .

Description of the problem being solved:

Adds support for the line "Life Recovery from Non-Instant Leech is not applied" from the Strength of Blood keystone

Steps taken to verify a working solution:

  • Add source of life leech and source of instant life leech
  • Add Strength of Blood of blood to a build
  • Verify only Instant Life Leech is part of Life Leech Rate in calcs

Link to a build that showcases this PR:

https://pobb.in/7kckh4cytUcH
Disabled imperial claws life gain on hit to make instant leech easier to identify

Without Strength of Blood:

image

With Strength of Blood:

image

@Paliak Paliak added the enhancement New feature, calculation, or mod label Jul 26, 2024
@Paliak
Copy link
Contributor

Paliak commented Jul 26, 2024

Generally if there isn't an associated issue on the tracker remove the Fixes # . in the future.

@Paliak
Copy link
Contributor

Paliak commented Jul 26, 2024

Related #7850

@LocalIdentity LocalIdentity merged commit b2304c5 into PathOfBuildingCommunity:dev Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants