Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rallying Cry Exerted damage mod not working with Autoexertion #7914

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

LocalIdentity
Copy link
Contributor

I assumed the damage benefit was a part of the buff so had it in the wrong block of code
Fixes #7899

I assumed the damage benefit was a part of the buff so had it in the wrong block of code
@LocalIdentity LocalIdentity added the bug: calculation Numerical differences label Jul 24, 2024
@LocalIdentity LocalIdentity merged commit 3b2fe85 into dev Jul 25, 2024
2 checks passed
@LocalIdentity LocalIdentity deleted the fix_rallying-autoexertion branch July 25, 2024 01:49
@evovolvo
Copy link

Is it confirmed anywhere that rallying cry actually works with autoexertion?
Cause the minions do not get the buff.

@LocalIdentity
Copy link
Contributor Author

@evovolvo I checked with GGG and it should not be working with Autoexertion. I'm reverting this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: calculation Numerical differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AutoExerted Seismic Cry and RallyingCry
2 participants