Fix Arcane Surge not working with Wilma's Requital #7872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalIdentity
approved these changes
Jul 23, 2024
LocalIdentity
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7869 .
Description of the problem being solved:
Arcane Surge cast speed increase was tagged as
ModFlag.Spell, being the only Speed increase tagged like this.Changed it to
ModFlag.Cast, which allows Wilma's Requitals "Increases and Reductions to Cast Speed apply to Attack Speed" to use the Arcane Surge cast speed.Link to a build that showcases this PR:
https://pobb.in/vaSKByGO7J4G
Toggling Arcane Surge in config will change the attack speed of Kinetic Bolt after fix.
Tested against an involved Hierophant PoB using Arcane Surge effects, could not find any difference.