Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix config set copies not having independent values #7867

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Fix config set copies not having independent values #7867

merged 1 commit into from
Jul 23, 2024

Conversation

justjuangui
Copy link
Contributor

Fixes #7852 .

When you select a config set and hit the copy button, that action copy the top object but keep reference for internal tables.
image

This MR allow to do copyTable in deep mode
image

@Wires77 Wires77 merged commit 709a845 into PathOfBuildingCommunity:dev Jul 23, 2024
2 checks passed
@Wires77 Wires77 added the bug Something isn't working label Jul 23, 2024
@Wires77 Wires77 changed the title Enable recursive copyTable for ConfigSet Fix #7852 Fix config set copies not having independent values Jul 23, 2024
@justjuangui justjuangui deleted the 7852-hotfix-configset-copy branch July 23, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wires77 Wires77 Wires77 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Config Sets create copy linked together
2 participants
@justjuangui @Wires77