Match single sets to loadouts more effectively #7846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deathbeam
force-pushed
the
use-explicit-match
branch
from
8f175a6 to
6cc9704
Compare
|
What about for a single Tree? I don't think this is supported in live even now with group Loadouts and I don't see a huge need for it but if we're not going to, the third condition in Help should be updated to say so |
|
Found an issue, but I'm not sure it's caused by this PR or if it's just a side effect:
|
Instead of assigning 1 size sets to existing loadout links, just check for this when the loadouts are being matched instead. Its more reliable and do not relies on links to be filled (in case of name match sets for example). Signed-off-by: Tomas Slusny <[email protected]>
Signed-off-by: Tomas Slusny <[email protected]>
deathbeam
force-pushed
the
use-explicit-match
branch
from
6cc9704 to
6c5a950
Compare
This was also problem on master, loadout selection wasnt resynced on active set change. Pushed commit that will fix it here |
Signed-off-by: Tomas Slusny <[email protected]>
Updated te help file |
deathbeam
force-pushed
the
use-explicit-match
branch
from
2899b83 to
c43672d
Compare
Wires77
approved these changes
Jul 25, 2024
Wires77
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of assigning 1 size sets to existing loadout links, just check for this when the loadouts are being matched instead. Its more reliable and do not relies on links to be filled (in case of name match sets for example).
Link to a build that showcases this PR:
Loadouts with groups: https://pobb.in/u/thedeathbeam/pf-poison-scourge-arrow
Default loadout with names: https://pobb.in/u/thedeathbeam/pf-poison-spark
Abc loadout with config being "Default": https://pobb.in/jdpxU9ADNlGF