Skip to content

Commit

Permalink
Fix Banner skills not applying to Minions (#7922)
Browse files Browse the repository at this point in the history 
The previous condition check was checking for mod on the player which would break the mods when applied to minions
This doesn't work with the Party tab still though

Co-authored-by: LocalIdentity <[email protected]>
  • Loading branch information
@LocalIdentity
LocalIdentity and LocalIdentity authored Jul 25, 2024
1 parent 835d2a5 commit b12b727
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 10 deletions.
15 changes: 9 additions & 6 deletions src/Data/Skills/act_str.lua
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2205,10 +2205,10 @@ skills["DefianceBanner"] = {
castTime = 0,
statMap = {
["defiance_banner_movement_speed"] = {
mod("MovementSpeed", "INC", nil, 0, 0, { type = "GlobalEffect", effectType = "Aura" }, { type = "Condition", var = "BannerPlanted" }),
mod("MovementSpeed", "INC", nil, 0, 0, { type = "GlobalEffect", effectType = "Aura" }),
},
["suppress_spell_damage"] = {
mod("SpellSuppressionChance", "BASE", nil, 0, 0, { type = "GlobalEffect", effectType = "Aura" }, { type = "Condition", var = "BannerPlanted" }),
mod("SpellSuppressionChance", "BASE", nil, 0, 0, { type = "GlobalEffect", effectType = "Aura" }),
},
},
baseFlags = {
Expand All @@ -2220,6 +2220,7 @@ skills["DefianceBanner"] = {
},
baseMods = {
skill("radius", 24),
mod("AuraEffect", "MORE", -100, 0, 0, { type = "Condition", var = "BannerPlanted", neg = true }),
flag("Condition:AffectedByPlacedBanner", { type = "Condition", var = "BannerPlanted" }, { type = "GlobalEffect", effectType = "Buff" }),
},
qualityStats = {
Expand Down Expand Up @@ -2721,17 +2722,18 @@ skills["PuresteelBanner"] = {
castTime = 0,
statMap = {
["puresteel_banner_accuracy_rating_+%_final"] = {
mod("LifeOnBlock", "BASE", nil, 0, 0, { type = "GlobalEffect", effectType = "Aura" }, { type = "Condition", var = "BannerPlanted" }),
mod("LifeOnBlock", "BASE", nil, 0, 0, { type = "GlobalEffect", effectType = "Aura" }),
},
["attacks_impale_on_hit_%_chance"] = {
mod("BlockChance", "BASE", nil, 0, 0, { type = "GlobalEffect", effectType = "Aura" }, { type = "Condition", var = "BannerPlanted" }),
mod("BlockChance", "BASE", nil, 0, 0, { type = "GlobalEffect", effectType = "Aura" }),
},
},
baseFlags = {
spell = true,
},
baseMods = {
skill("radius", 24),
mod("AuraEffect", "MORE", -100, 0, 0, { type = "Condition", var = "BannerPlanted", neg = true }),
flag("Condition:AffectedByPlacedBanner", { type = "Condition", var = "BannerPlanted" }, { type = "GlobalEffect", effectType = "Buff" }),
},
qualityStats = {
Expand Down Expand Up @@ -11302,17 +11304,18 @@ skills["BloodstainedBanner"] = {
castTime = 0,
statMap = {
["accuracy_rating_+%"] = {
mod("Accuracy", "INC", nil, 0, 0, { type = "GlobalEffect", effectType = "Aura" }, { type = "Condition", var = "BannerPlanted" })
mod("Accuracy", "INC", nil, 0, 0, { type = "GlobalEffect", effectType = "Aura" })
},
["physical_damage_+%"] = {
mod("PhysicalDamage", "MORE", nil, 0, 0, { type = "GlobalEffect", effectType = "Aura" }, { type = "Condition", var = "BannerPlanted" }, { type = "SkillType", skillType = SkillType.Melee }),
mod("PhysicalDamage", "MORE", nil, 0, 0, { type = "GlobalEffect", effectType = "Aura" }, { type = "SkillType", skillType = SkillType.Melee }),
},
},
baseFlags = {
spell = true,
},
baseMods = {
skill("radius", 24),
mod("AuraEffect", "MORE", -100, 0, 0, { type = "Condition", var = "BannerPlanted", neg = true }),
flag("Condition:AffectedByPlacedBanner", { type = "Condition", var = "BannerPlanted" }, { type = "GlobalEffect", effectType = "Buff" }),
},
qualityStats = {
Expand Down
11 changes: 7 additions & 4 deletions src/Export/Skills/act_str.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -403,13 +403,14 @@ local skills, mod, flag, skill = ...
#flags spell area duration aura banner
statMap = {
["defiance_banner_movement_speed"] = {
mod("MovementSpeed", "INC", nil, 0, 0, { type = "GlobalEffect", effectType = "Aura" }, { type = "Condition", var = "BannerPlanted" }),
mod("MovementSpeed", "INC", nil, 0, 0, { type = "GlobalEffect", effectType = "Aura" }),
},
["suppress_spell_damage"] = {
mod("SpellSuppressionChance", "BASE", nil, 0, 0, { type = "GlobalEffect", effectType = "Aura" }, { type = "Condition", var = "BannerPlanted" }),
mod("SpellSuppressionChance", "BASE", nil, 0, 0, { type = "GlobalEffect", effectType = "Aura" }),
},
},
#baseMod skill("radius", 24
#baseMod mod("AuraEffect", "MORE", -100, 0, 0, { type = "Condition", var = "BannerPlanted", neg = true })
#baseMod flag("Condition:AffectedByPlacedBanner", { type = "Condition", var = "BannerPlanted" }, { type = "GlobalEffect", effectType = "Buff" })
#mods

Expand Down Expand Up @@ -470,13 +471,14 @@ local skills, mod, flag, skill = ...
#flags spell
statMap = {
["puresteel_banner_accuracy_rating_+%_final"] = {
mod("LifeOnBlock", "BASE", nil, 0, 0, { type = "GlobalEffect", effectType = "Aura" }, { type = "Condition", var = "BannerPlanted" }),
mod("LifeOnBlock", "BASE", nil, 0, 0, { type = "GlobalEffect", effectType = "Aura" }),
},
["attacks_impale_on_hit_%_chance"] = {
mod("BlockChance", "BASE", nil, 0, 0, { type = "GlobalEffect", effectType = "Aura" }, { type = "Condition", var = "BannerPlanted" }),
mod("BlockChance", "BASE", nil, 0, 0, { type = "GlobalEffect", effectType = "Aura" }),
},
},
#baseMod skill("radius", 24)
#baseMod mod("AuraEffect", "MORE", -100, 0, 0, { type = "Condition", var = "BannerPlanted", neg = true })
#baseMod flag("Condition:AffectedByPlacedBanner", { type = "Condition", var = "BannerPlanted" }, { type = "GlobalEffect", effectType = "Buff" })
#mods

Expand Down Expand Up @@ -2052,5 +2054,6 @@ local skills, mod, flag, skill = ...
},
},
#baseMod skill("radius", 24)
#baseMod mod("AuraEffect", "MORE", -100, 0, 0, { type = "Condition", var = "BannerPlanted", neg = true })
#baseMod flag("Condition:AffectedByPlacedBanner", { type = "Condition", var = "BannerPlanted" }, { type = "GlobalEffect", effectType = "Buff" })
#mods

0 comments on commit b12b727

Please sign in to comment.