-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update APC_costs.qmd with details on APC extrapolation #20
Conversation
Added some details on extrapolating unkonwn APCs, in past and future data.
Thank you for this! Very much appreciated. I will take a closer look this Tuesday. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, and apologies for the late review!
The second paragraph, based on the Bracco et al. paper, seems to make most sense to me. The methodology in the first paragraph seems too general, and I'm not sure if inferring the APC based on the impact would be something desireable to promote for imputation (even if it may be predictive). The methodology in the third paragraph (which is your own methodology, if I understand correctly?) seems a bit more complex. In principle, it is not a problem to have more complex methodologies described, but I'm not sure what is the added value of it compared to Bracco et al.?
Given that @igrypari and @PetrosStav were involved in the writing, it might also be good to get their input. |
OK, @igrypari let me know via mail that there are no further comments. Let me clean it up a bit according to my comments above, and then I'll merge... Thanks! |
Thanks again @Enro! Feel free to open any other PR if you have anything else in the future! |
Added some details on extrapolating unknown APCs, in past and future data.