Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put auto sub behind dev flags #711

Merged
merged 1 commit into from
Apr 29, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/services/BackgroundTaskService.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { HCAService } from '../services/HCAService';

export function executeTask() {
checkIntersect();
HCAService.findNewAuthorities();
__DEV__ && HCAService.findNewAuthorities();
}

export default class BackgroundTaskServices {
Expand Down
16 changes: 9 additions & 7 deletions app/views/ChooseProvider.js
Original file line number Diff line number Diff line change
Expand Up @@ -235,13 +235,15 @@ class ChooseProviderScreen extends Component {
<Typography style={styles.sectionDescription} use={'body1'}>
{languages.t('label.authorities_desc')}
</Typography>
<TouchableOpacity style={styles.autoSubcribe}>
<Checkbox
label={languages.t('label.auto_subscribe_checkbox')}
checked={this.state.isAutoSubscribed}
onPress={() => this.toggleAutoSubscribe()}
/>
</TouchableOpacity>
{__DEV__ && (
<TouchableOpacity style={styles.autoSubcribe}>
<Checkbox
label={languages.t('label.auto_subscribe_checkbox')}
checked={this.state.isAutoSubscribed}
onPress={() => this.toggleAutoSubscribe()}
/>
</TouchableOpacity>
)}
</View>

<View style={styles.listContainer}>
Expand Down
20 changes: 14 additions & 6 deletions app/views/onboarding/Onboarding5.js
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ class Onboarding extends Component {
componentDidMount() {
this.checkLocationStatus();
isPlatformiOS() && this.checkNotificationStatus();
this.checkSubsriptionStatus();
__DEV__ && this.checkSubsriptionStatus();
}

isLocationChecked() {
Expand All @@ -106,11 +106,9 @@ class Onboarding extends Component {
getNextStep(currentStep) {
switch (currentStep) {
case StepEnum.LOCATION:
return isPlatformiOS()
? StepEnum.NOTIFICATIONS
: StepEnum.HCA_SUBSCRIPTION;
return this.getLocationNextStep();
case StepEnum.NOTIFICATIONS:
return StepEnum.HCA_SUBSCRIPTION;
return __DEV__ ? StepEnum.HCA_SUBSCRIPTION : StepEnum.DONE;
case StepEnum.HCA_SUBSCRIPTION:
return StepEnum.DONE;
}
Expand Down Expand Up @@ -175,6 +173,16 @@ class Onboarding extends Component {
}
}

getLocationNextStep() {
if (isPlatformiOS()) {
return StepEnum.NOTIFICATIONS;
} else if (__DEV__) {
return StepEnum.HCA_SUBSCRIPTION;
} else {
return isPlatformiOS() ? StepEnum.NOTIFICATIONS : StepEnum.DONE;
}
}

/**
* Gets the respective location permissions settings string
* for the user's current device.
Expand Down Expand Up @@ -427,7 +435,7 @@ class Onboarding extends Component {
<View style={styles.statusContainer}>
{this.getLocationPermission()}
{this.getNotificationsPermissionIfIOS()}
{this.getAuthSubscriptionStatus()}
{__DEV__ && this.getAuthSubscriptionStatus()}
<View style={styles.spacer} />
</View>
</View>
Expand Down
14 changes: 1 addition & 13 deletions e2e/helpers/onboarding.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,20 +23,8 @@ export const navigateThroughPermissions = async languageStrings => {
await Onboarding4.tapButton(languageStrings);
};

export const navigateThroughOnboarding = async (
languageStrings,
isAutoSubcribe = true,
) => {
export const navigateThroughOnboarding = async languageStrings => {
await navigateThroughPermissions(languageStrings);

await EnableAuthoritySubscription.isOnScreen(languageStrings);

if (isAutoSubcribe) {
await EnableAuthoritySubscription.enable(languageStrings);
} else {
await EnableAuthoritySubscription.skipStep(languageStrings);
}

await FinishSetup.isOnScreen(languageStrings);
await FinishSetup.takeScreenshot(languageStrings);
await FinishSetup.tapButton(languageStrings);
Expand Down
35 changes: 0 additions & 35 deletions e2e/onboarding/NoAuthSubscriptionPermission.spec.js

This file was deleted.