Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge bitcoin#29753: test: fix StopIteration exception in p2p_node_ne…
…twork_limited.py 2eb5175 test: fix StopIteration exception in p2p_node_network_limited.py (furszy) Pull request description: Fixes bitcoin#29731 The `next()` call throws an exception if the default parameter is omitted and the iterator is exhausted. Fix it by providing a default value. The failure can be tested by commenting out lines 90 and 91 in the test (the `self.connect_nodes(2, 0)`). Since there is no connection, the node in question retrieves a single element in the 'getchaintips()' call. This scenario without the fix, aborts the test right away, throwing an `StopIteration` exception, and with the fix, the test properly waits until the timeout (`wait_until()` call). ACKs for top commit: maflcko: review ACK 2eb5175 brunoerg: crACK 2eb5175 BrandonOdiwuor: crACK 2eb5175 tdb3: Tested ACK for 2eb5175. Tree-SHA512: b0873eb4d3334146fd250cd2cd23add3e744877033c8bfa4eb8dff36633100604adf49dd7846856ddfa88c9768663f095db705c00eef3641618df8fc13f8c2c5
- Loading branch information