added test for fail case

fixed bug with verifying password with hash
PascalBenstrong · Jan 29, 2022 · 3437244 · 3437244
1 parent 6481f00
commit 3437244
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 6 deletions.
diff --git a/FluentPasswordHashing/PasswordHashArguments.cs b/FluentPasswordHashing/PasswordHashArguments.cs
@@ -1,6 +1,6 @@
 namespace FluentPasswordHashing
 {
-    internal class PasswordHashArguments
+    internal record PasswordHashArguments
     {
         /// <summary>
         /// Argon2 hash algorithm to use

diff --git a/FluentPasswordHashing/Utils.cs b/FluentPasswordHashing/Utils.cs
@@ -38,11 +38,10 @@ private static async ValueTask<byte[]> HashPassword(char[] password, PasswordHas
         internal static async ValueTask<PasswordHashArguments> GenerateArgumentsWithHash(PasswordHashArguments arguments, char[] password, int saltLength = 16)
         {
             var salt = arguments.Salt ?? CreateSalt(saltLength);
-            var hash = await HashPassword(password,arguments).ConfigureAwait(false);
+            arguments = arguments with { Salt = salt };
+            var hash = await HashPassword(password, arguments).ConfigureAwait(false);
 
-            arguments.Salt = salt;
-            arguments.Hash = hash;
-            return arguments;
+            return arguments with { Hash = hash };
         }
 
         internal static ValueTask<PasswordHashArguments> GenerateArgumentsWithHash(PasswordHashArguments arguments, string password, int saltLength = 16)

diff --git a/UnitTest.FluentPasswordHashing/FluentPasswordHashingTests.cs b/UnitTest.FluentPasswordHashing/FluentPasswordHashingTests.cs
@@ -34,7 +34,7 @@ public async Task Generating_A_Hash_Should_Pass()
         }
 
         [Theory]
-        [InlineData("$argon2id$m=16,t=4,p=1$aM8qmYw1xfzvHEYTIg0w1g==$5Hg1fRhHv1uOnOMusawtqg==", "password")]
+        [InlineData("$argon2id$m=16,t=4,p=1$aM8qmYw1xfzvHEYTIg0w1g==$mQqnrY9rQyMC7SJq039z/A==", "password")]
         public async Task Verifying_Password_And_Hash_Should_Pass(string hash, string password)
         {
             // arrange
@@ -48,5 +48,21 @@ public async Task Verifying_Password_And_Hash_Should_Pass(string hash, string pa
             // assert
             isMatch.Should().BeTrue();
         }
+
+        [Theory]
+        [InlineData("$argon2id$m=16,t=4,p=1$aM8qmYw1xfzvHEYTIg0w1g==$mQqnrY9rQyMC7SJq039z/A==", "wrong password")]
+        public async Task Verifying_Password_And_Hash_Should_Fail(string hash, string password)
+        {
+            // arrange
+            var generator = FluentHashing.Create()
+                .Generator();
+
+            // act
+            var isMatch = await generator.VerifyPassword(hash, password);
+
+
+            // assert
+            isMatch.Should().BeFalse();
+        }
     }
 }