Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a market wrapper for Fractional auctions.
Summary of Addition and Changes
Contracts
FractionalMarketWrapper.sol
.PartyBid.sol
is slightly changed (v4
) to accommodate rebalancing itswETH
andETH
balances. The changes are not required if the party is winning or it has not placed a bid yet. It is only necessary if the party has lost or themultisig
is forcing the party to lose. Every time thebid
function is called the call is delegated toFractionalMarketWrapper
'sbid(uint256 auctionId, uint256 bidAmount)
and there we are also making sure thewETH
is withdrawn to party's balance.Tests
Fractional
auction ends usingevm_increaseTime
method, we added a new constantEIGHT_DAYS_IN_SECONDS
and for the tests regardingFractional
that value has been used.wETH + ETH
balance to be invariant forFractional
auctions instead of onlyPartyBid
'sETH
balance.ERC721TokenVault.sol
uses a hardcoded/constantweth
address, a constant for0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2
is also created and by using thehardhat_setCode
method we etch the compiled runtime bytecode forEtherToken
at that address.All tests are passing. For running the tests faster use the following command: