Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: settable-fee-recipient-crowdfund #393

Merged
merged 4 commits into from
Apr 26, 2024

Conversation

arr00
Copy link
Contributor

@arr00 arr00 commented Apr 15, 2024

Link T-4746

Copy link

height bot commented Apr 15, 2024

This pull request has been linked to 1 task:

💡Tip: Add "Close T-4746" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

Copy link

Gas Report:
Accept Proposal: 31749
Create party custom metadata: 726170
Create party vanilla: 296856
Contribute to ETH party: 204946
Batch contribute two memberships to ETH party: 278336
Create proposal transfer eth: 141169
Execute proposal transfer eth: 123058
Create proposal distribute: 139523
Execute proposal distribute: 232549
Claim distribution: 74905

@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 66.22%. Comparing base (d96338e) to head (561e7ba).

Files Patch % Lines
contracts/crowdfund/ERC20LaunchCrowdfund.sol 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #393      +/-   ##
==========================================
- Coverage   66.28%   66.22%   -0.07%     
==========================================
  Files          71       71              
  Lines        3005     3008       +3     
  Branches      654      655       +1     
==========================================
  Hits         1992     1992              
- Misses        806      809       +3     
  Partials      207      207              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arr00 arr00 marked this pull request as ready for review April 16, 2024 16:44
@arr00 arr00 requested a review from 0xble April 16, 2024 16:44
@arr00 arr00 merged commit a9465ed into main Apr 26, 2024
6 checks passed
@arr00 arr00 deleted the feat/settable-fee-recipient-crowdfund branch April 26, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants