Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add EZPartyBuilder #375

Merged
merged 9 commits into from
Feb 22, 2024
Merged

feat: add EZPartyBuilder #375

merged 9 commits into from
Feb 22, 2024

Conversation

0xble
Copy link
Collaborator

@0xble 0xble commented Feb 8, 2024

No description provided.

Copy link

height bot commented Feb 8, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

github-actions bot commented Feb 8, 2024

Gas Report:

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8245386) 66.70% compared to head (389bd50) 66.82%.

Files Patch % Lines
contracts/utils/EZPartyBuilder.sol 88.23% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #375      +/-   ##
==========================================
+ Coverage   66.70%   66.82%   +0.12%     
==========================================
  Files          69       70       +1     
  Lines        2946     2963      +17     
  Branches      644      647       +3     
==========================================
+ Hits         1965     1980      +15     
  Misses        783      783              
- Partials      198      200       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arr00
Copy link
Contributor

arr00 commented Feb 8, 2024

I think a better place for this file is contracts/utils. Seems out of place with the party contracts.

Copy link
Contributor

@arr00 arr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall

test/party/EZPartyBuilder.t.sol Outdated Show resolved Hide resolved
contracts/party/EZPartyBuilder.sol Outdated Show resolved Hide resolved

hasAlreadyCreatedParty[host] = true;

PartyNFTRenderer.Metadata memory metadata;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets set the rendering method to FixedCrowdfund

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FE has been setting name and collectionName so lets do that as well.

contracts/party/EZPartyBuilder.sol Outdated Show resolved Hide resolved
@arr00
Copy link
Contributor

arr00 commented Feb 13, 2024

I think a better place for this file is contracts/utils. Seems out of place with the party contracts.

Other than this looks good

Copy link
Contributor

@arr00 arr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This contract does not belong in the party folder

@0xble 0xble merged commit 136ed9b into main Feb 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants