-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add EZPartyBuilder
#375
Conversation
|
Gas Report: |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #375 +/- ##
==========================================
+ Coverage 66.70% 66.82% +0.12%
==========================================
Files 69 70 +1
Lines 2946 2963 +17
Branches 644 647 +3
==========================================
+ Hits 1965 1980 +15
Misses 783 783
- Partials 198 200 +2 ☔ View full report in Codecov by Sentry. |
I think a better place for this file is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall
contracts/party/EZPartyBuilder.sol
Outdated
|
||
hasAlreadyCreatedParty[host] = true; | ||
|
||
PartyNFTRenderer.Metadata memory metadata; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets set the rendering method to FixedCrowdfund
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FE has been setting name
and collectionName
so lets do that as well.
Other than this looks good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This contract does not belong in the party folder
No description provided.