Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mitigations: #306 (QA-2, QA-3, QA-5) #354

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Conversation

0xble
Copy link
Collaborator

@0xble 0xble commented Dec 1, 2023

Copy link

height bot commented Dec 1, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@0xble 0xble requested a review from arr00 December 1, 2023 18:56
@0xble 0xble requested a review from arr00 December 1, 2023 21:41
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (03d9e47) 65.44% compared to head (f241a90) 65.30%.
Report is 1 commits behind head on c4-mitigations.

Files Patch % Lines
contracts/crowdfund/ETHCrowdfundBase.sol 33.33% 1 Missing and 1 partial ⚠️
contracts/party/PartyGovernance.sol 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           c4-mitigations     #354      +/-   ##
==================================================
- Coverage           65.44%   65.30%   -0.14%     
==================================================
  Files                  68       68              
  Lines                2772     2784      +12     
  Branches              622      626       +4     
==================================================
+ Hits                 1814     1818       +4     
- Misses                762      766       +4     
- Partials              196      200       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arr00 arr00 merged commit 65334de into c4-mitigations Dec 4, 2023
5 checks passed
@arr00 arr00 deleted the mitigations/306-QA2-3-5 branch December 4, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants