Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitigation: 191 R01 #340

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Mitigation: 191 R01 #340

merged 1 commit into from
Nov 29, 2023

Conversation

arr00
Copy link
Contributor

@arr00 arr00 commented Nov 22, 2023

Standardize batch contribute functions in InitialETHCrowdfund. C4 191.

Copy link

height bot commented Nov 22, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@arr00 arr00 changed the base branch from main to dev November 22, 2023 20:08
@arr00 arr00 requested a review from 0xble November 22, 2023 20:08
@arr00 arr00 closed this Nov 22, 2023
@arr00 arr00 reopened this Nov 22, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d2d01da) 65.56% compared to head (3027de0) 65.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #340      +/-   ##
==========================================
+ Coverage   65.56%   65.63%   +0.06%     
==========================================
  Files          68       68              
  Lines        2733     2735       +2     
  Branches      619      619              
==========================================
+ Hits         1792     1795       +3     
  Misses        744      744              
+ Partials      197      196       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Gas Report:
Accept Proposal: 32228
Create party custom metadata: 728006
Create party vanilla: 298639
Contribute to ETH party: 202800
Batch contribute two memberships to ETH party: 275596
Create proposal transfer eth: 140956
Execute proposal transfer eth: 123384
Create proposal distribute: 139310
Execute proposal distribute: 227670
Claim distribution: 72007

@arr00 arr00 merged commit 138a7c6 into c4-mitigations Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants