Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: require distributionsRequireVote to enable rage quit #333

Merged

Conversation

0xble
Copy link
Collaborator

@0xble 0xble commented Nov 22, 2023

@0xble 0xble requested a review from arr00 November 22, 2023 18:38
Copy link

height bot commented Nov 22, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

Gas Report:
Accept Proposal: 32228
Create party custom metadata: 725782
Create party vanilla: 296415
Contribute to ETH party: 204800
Batch contribute two memberships to ETH party: 277593
Create proposal transfer eth: 140956
Execute proposal transfer eth: 123384
Create proposal distribute: 139310
Execute proposal distribute: 227670
Claim distribution: 72007

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (98e684c) 65.24% compared to head (fc6a94e) 65.64%.

❗ Current head fc6a94e differs from pull request most recent head 68c0f3c. Consider uploading reports for the commit 68c0f3c to get more accurate results

Additional details and impacted files
@@                Coverage Diff                 @@
##           c4-mitigations     #333      +/-   ##
==================================================
+ Coverage           65.24%   65.64%   +0.40%     
==================================================
  Files                  68       68              
  Lines                2759     2739      -20     
  Branches              618      622       +4     
==================================================
- Hits                 1800     1798       -2     
+ Misses                763      744      -19     
- Partials              196      197       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arr00 arr00 force-pushed the fix/require-distributionsRequireVote-for-rage-quit branch from fc6a94e to 68c0f3c Compare November 29, 2023 20:06
@arr00 arr00 closed this Nov 29, 2023
@arr00 arr00 reopened this Nov 29, 2023
Copy link
Contributor

@arr00 arr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@0xble 0xble merged commit 9f5e9a5 into c4-mitigations Nov 30, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants