Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement membership sale #326

Closed
wants to merge 25 commits into from
Closed

feat: implement membership sale #326

wants to merge 25 commits into from

Conversation

0xble
Copy link
Collaborator

@0xble 0xble commented Oct 30, 2023

Link T-3519

@height
Copy link

height bot commented Oct 30, 2023

This pull request has been linked to 1 task:

💡Tip: Add "Close T-3519" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

@0xble 0xble force-pushed the feat/membership-sale branch from 327517f to 08e505f Compare October 31, 2023 19:50
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2023

Codecov Report

Attention: 44 lines in your changes are missing coverage. Please review.

Comparison is base (df8a02e) 65.56% compared to head (195dba2) 65.57%.

Files Patch % Lines
contracts/authorities/SellPartyCardsAuthority.sol 66.66% 39 Missing and 2 partials ⚠️
contracts/utils/LibSafeCast.sol 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##              dev     #326    +/-   ##
========================================
  Coverage   65.56%   65.57%            
========================================
  Files          68       69     +1     
  Lines        2733     2861   +128     
  Branches      619      636    +17     
========================================
+ Hits         1792     1876    +84     
- Misses        744      786    +42     
- Partials      197      199     +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xble 0xble force-pushed the feat/membership-sale branch from 195dba2 to e49ac09 Compare November 14, 2023 20:36
@0xble 0xble closed this Nov 14, 2023
@0xble
Copy link
Collaborator Author

0xble commented Nov 14, 2023

Replaced by #328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants