Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement ERC-1167 minimal proxies #289

Merged
merged 2 commits into from
Sep 22, 2023
Merged

feat: implement ERC-1167 minimal proxies #289

merged 2 commits into from
Sep 22, 2023

Conversation

0xble
Copy link
Collaborator

@0xble 0xble commented Sep 5, 2023

No description provided.

@height
Copy link

height bot commented Sep 5, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.18% 🎉

Comparison is base (5bce9b7) 61.18% compared to head (d7e8a9c) 61.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #289      +/-   ##
==========================================
+ Coverage   61.18%   61.36%   +0.18%     
==========================================
  Files          65       65              
  Lines        2535     2542       +7     
  Branches      592      591       -1     
==========================================
+ Hits         1551     1560       +9     
+ Misses        781      779       -2     
  Partials      203      203              
Files Changed Coverage Δ
contracts/crowdfund/AuctionCrowdfund.sol 100.00% <ø> (ø)
contracts/crowdfund/BuyCrowdfund.sol 82.60% <ø> (ø)
...ontracts/crowdfund/CollectionBatchBuyCrowdfund.sol 80.00% <ø> (ø)
contracts/crowdfund/CollectionBuyCrowdfund.sol 56.25% <ø> (ø)
contracts/crowdfund/InitialETHCrowdfund.sol 81.69% <ø> (ø)
contracts/crowdfund/ReraiseETHCrowdfund.sol 76.03% <ø> (ø)
contracts/crowdfund/RollingAuctionCrowdfund.sol 83.33% <ø> (ø)
contracts/party/Party.sol 100.00% <ø> (ø)
contracts/crowdfund/CrowdfundFactory.sol 94.44% <100.00%> (+1.34%) ⬆️
contracts/party/PartyFactory.sol 70.00% <100.00%> (+3.33%) ⬆️
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xble 0xble requested a review from arr00 September 20, 2023 16:52
Copy link
Contributor

@arr00 arr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still a few changes from #285 which are being reverted in this PR which seems to just be merge issues. These changes break the test suite. Any time that a forked test is used, it must be in a contract which has the suffix ForkedTest.

@0xble
Copy link
Collaborator Author

0xble commented Sep 21, 2023

There are still a few changes from #285 which are being reverted in this PR which seems to just be merge issues. These changes break the test suite. Any time that a forked test is used, it must be in a contract which has the suffix ForkedTest.

I think it's fixed now 😩

@0xble 0xble requested a review from arr00 September 21, 2023 12:43
@0xble 0xble requested a review from arr00 September 21, 2023 19:37
Copy link
Contributor

@arr00 arr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@0xble 0xble merged commit 5bcf75e into dev Sep 22, 2023
4 checks passed
arr00 pushed a commit that referenced this pull request Sep 22, 2023
arr00 pushed a commit that referenced this pull request Oct 2, 2023
arr00 pushed a commit that referenced this pull request Oct 2, 2023
arr00 pushed a commit that referenced this pull request Oct 4, 2023
arr00 pushed a commit that referenced this pull request Oct 16, 2023
arr00 pushed a commit that referenced this pull request Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants