-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement ERC-1167 minimal proxies #289
Conversation
|
4bb6044
to
69380c8
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #289 +/- ##
==========================================
+ Coverage 61.18% 61.36% +0.18%
==========================================
Files 65 65
Lines 2535 2542 +7
Branches 592 591 -1
==========================================
+ Hits 1551 1560 +9
+ Misses 781 779 -2
Partials 203 203
☔ View full report in Codecov by Sentry. |
9e80c7f
to
d10c032
Compare
69380c8
to
eb88ea6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still a few changes from #285 which are being reverted in this PR which seems to just be merge issues. These changes break the test suite. Any time that a forked test is used, it must be in a contract which has the suffix ForkedTest
.
22818a6
to
78581d7
Compare
I think it's fixed now 😩 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
No description provided.