-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(provider): add metadata provider using SSTORE2 #275
Conversation
This pull request has been linked to 1 task:
|
This metadata provider won't be compatible with the factory in it's current state. Would result in some overhead for frontend to migrate support. |
Good point. Fixed. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #275 +/- ##
==========================================
+ Coverage 60.66% 60.83% +0.16%
==========================================
Files 63 64 +1
Lines 2489 2510 +21
Branches 580 583 +3
==========================================
+ Hits 1510 1527 +17
- Misses 779 783 +4
Partials 200 200
☔ View full report in Codecov by Sentry. |
Closed in favor of #283 |
Link T-3200
After writing 32 bytes using SSTORE2 vs SSTORE becomes the cheaper option.