Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(renderer): metadata tweaks #273

Merged
merged 3 commits into from
Aug 23, 2023
Merged

refactor(renderer): metadata tweaks #273

merged 3 commits into from
Aug 23, 2023

Conversation

0xble
Copy link
Collaborator

@0xble 0xble commented Aug 22, 2023

Link T-3190

Example of updated custom description (default appended description now separated by newlines):

Hey. I'm a placeholder custom description. Just minding my own business.

This membership represents 10% voting power in Party of the Living Dead. Head to https://party.app/party/0x4da6feb8f32416e7ad1e0795742cd64d5b8b8836 to view the Party's latest activity.

Example of metadata when custom banner is set (should always use custom banner if set):

{"name":"CUSTOM_COLLECTION_NAME", "description":"CUSTOM_COLLECTION_DESCRIPTION", "external_url":"CUSTOM_COLLECTION_EXTERNAL_URL", "image":"CUSTOM_IMAGE", "banner":"CUSTOM_BANNER"}

Example of metadata when NO custom banner and custom image is set (should not include banner attribute, blank):

{"name":"CUSTOM_COLLECTION_NAME", "description":"CUSTOM_COLLECTION_DESCRIPTION", "external_url":"CUSTOM_COLLECTION_EXTERNAL_URL", "image":"CUSTOM_IMAGE"}

Example of metadata when NO custom banner and default image is set (should use default Party banner):

{"name":"CUSTOM_COLLECTION_NAME", "description":"CUSTOM_COLLECTION_DESCRIPTION", "external_url":"CUSTOM_COLLECTION_EXTERNAL_URL", "image":"ipfs://QmZKE4XkPvU7Z8CdgK2Cn7gLQ4t8CDkkfnR1j5bZ2AfRJu", "banner":"ipfs://QmTKCqLUQJt3VxGuUqLMj1jcCRRsaZwY4k757Wb7YPzmH2"}

@0xble 0xble requested a review from arr00 August 22, 2023 15:16
@height
Copy link

height bot commented Aug 22, 2023

This pull request has been linked to 1 task:

  • T-3190 Update banner image for custom NFTs to be white background image (unlink task)

💡Tip: Add "Close T-3190" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.15% 🎉

Comparison is base (1ed51d0) 60.51% compared to head (ffac370) 60.66%.
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #273      +/-   ##
==========================================
+ Coverage   60.51%   60.66%   +0.15%     
==========================================
  Files          63       63              
  Lines        2477     2489      +12     
  Branches      576      580       +4     
==========================================
+ Hits         1499     1510      +11     
  Misses        779      779              
- Partials      199      200       +1     
Files Changed Coverage Δ
contracts/renderers/PartyNFTRenderer.sol 66.41% <ø> (+0.25%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xble 0xble merged commit 840ddec into dev Aug 23, 2023
4 checks passed
arr00 pushed a commit that referenced this pull request Aug 28, 2023
* refactor(renderer): update banner logic + update custom description

* fix: add missing bracket

* fix: lint
arr00 pushed a commit that referenced this pull request Aug 28, 2023
* refactor(renderer): update banner logic + update custom description

* fix: add missing bracket

* fix: lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants