Skip to content

Commit

Permalink
avoid duplicate testing
Browse files Browse the repository at this point in the history
  • Loading branch information
arr00 committed Aug 31, 2023
1 parent 598a234 commit a80f7b7
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
6 changes: 3 additions & 3 deletions test/crowdfund/InitialETHCrowdfund.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import "../../contracts/gatekeepers/AllowListGateKeeper.sol";

import "../TestUtils.sol";

contract InitialETHCrowdfundBaseTest is Test, TestUtils, ERC721Receiver {
contract InitialETHCrowdfundTestBase is Test, TestUtils, ERC721Receiver {
event Contributed(
address indexed sender,
address indexed contributor,
Expand Down Expand Up @@ -133,7 +133,7 @@ contract InitialETHCrowdfundBaseTest is Test, TestUtils, ERC721Receiver {
}
}

contract InitialETHCrowdfundTest is InitialETHCrowdfundBaseTest {
contract InitialETHCrowdfundTest is InitialETHCrowdfundTestBase {
function test_initialization_cannotReinitialize() public {
InitialETHCrowdfund crowdfund = _createCrowdfund(
CreateCrowdfundArgs({
Expand Down Expand Up @@ -1677,7 +1677,7 @@ contract InitialETHCrowdfundTest is InitialETHCrowdfundBaseTest {
}
}

contract InitialETHCrowdfundForkedTest is InitialETHCrowdfundBaseTest {
contract InitialETHCrowdfundForkedTest is InitialETHCrowdfundTestBase {
function testForked_partyCardTokenURI_whileCrowdfundActive() public onlyForked {
InitialETHCrowdfund crowdfund = _createCrowdfund(
CreateCrowdfundArgs({
Expand Down
6 changes: 4 additions & 2 deletions test/party/PartyGovernanceNFT.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import "../DummyERC721.sol";
import "../TestUsers.sol";
import "../TestUtils.sol";

contract PartyGovernanceNFTTest is Test, TestUtils {
contract PartyGovernanceNFTTestBase is Test, TestUtils {
Party partyImpl;
PartyFactory partyFactory;
DummySimpleProposalEngineImpl eng;
Expand Down Expand Up @@ -90,7 +90,9 @@ contract PartyGovernanceNFTTest is Test, TestUtils {
toadz = new DummyERC721();
toadz.mint(nftHolderAddress);
}
}

contract PartyGovernanceNFTTest is PartyGovernanceNFTTestBase {
function testMint() external {
(Party party, , ) = partyAdmin.createParty(
partyImpl,
Expand Down Expand Up @@ -1611,7 +1613,7 @@ contract DummyParty is ReadOnlyDelegateCall {
}
}

contract PartyGovernanceNFTForkedTest is PartyGovernanceNFTTest {
contract PartyGovernanceNFTForkedTest is PartyGovernanceNFTTestBase {
function testTokenURI_withFixedCrowdfundType() public onlyForked {
// Create party
DummyParty party = new DummyParty(address(globals), "Party of the Living Dead");
Expand Down

0 comments on commit a80f7b7

Please sign in to comment.