Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate logging and change logging levels of few loggings #847

Merged
merged 3 commits into from
Apr 9, 2019

Conversation

ZhuozhaoLi
Copy link
Contributor

The changes in this PR:

  1. Remove a duplicate logging line.
  2. Change logging level of several lines from debug to info level, so that they won't slow down the interchange.

@benclifford
Copy link
Collaborator

benclifford commented Apr 4, 2019

This PR is failing CI because:

pytest-xdist 1.28.0 has requirement pytest>=4.4.0, but you'll have pytest 3.7.1 which is incompatible.

which is possibly because test-requirements.txt has a restriction on pytest versions, but not on pytest-xdist.

The version of pytest-xdist in my development virtualenv is 1.26.1

This probably means that a clean build from master will also fail, and it would be appropriate to have a separate PR to fix this problem - perhaps by pinning pytest-xdist to 1.26.1, because there is a reason that the version on pytest is pinned - see 4355ef8

@benclifford
Copy link
Collaborator

see #850 for a potential CI fix.

Copy link
Member

@yadudoc yadudoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These change look good to go.

@yadudoc yadudoc merged commit 2bc571c into master Apr 9, 2019
@yadudoc yadudoc deleted the fix_logging_in_interchange branch April 9, 2019 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants