Create and close ZMQ sockets on utilizing thread #3774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khk-globus
force-pushed
the
ppw_threadwise_zmq_socks
branch
from
4809158 to
ee2f975
Compare
The ZMQ documentation is quite clear about not sharing ZMQ sockets between threads. This case wasn't so much shared as simply created on the main thread and _used_ in the child threads. "Probably" okay, and hasn't appeared to have bitten us to date ... regardless, be cleaner, and in so doing recognize that these aren't actually class variables.
khk-globus
force-pushed
the
ppw_threadwise_zmq_socks
branch
from
ee2f975 to
efe9b93
Compare
benclifford
approved these changes
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ZMQ documentation is quite clear about not sharing ZMQ sockets between threads. This case wasn't so much shared as simply created on the main thread and used in the child threads. "Probably" okay, and hasn't appeared to have bitten us to date ... regardless, be cleaner, and in so doing recognize that these aren't actually class variables.
Changed Behaviour
Slightly different logging output, as the result and task ZMQ pipes are now connecting in different threads.
Type of change