Remove channel closing at shutdown #3685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalChannel, the only extant channel, does not have any close() behaviour. This is part of #3515 channel removal.
khk-globus
approved these changes
Nov 7, 2024
Comment on lines
-84
to
-89
| @abstractmethod | ||
| def close(self) -> None: | ||
| ''' Closes the channel. | ||
| ''' | ||
| pass | ||
|
|
There was a problem hiding this comment.
This hunk ... is debatable. Channels are going away anyway, so "whatever."
There was a problem hiding this comment.
removing it helps flush out where it was called for the typechecker. sometimes.
my thinking mostly is that I would like to remove all the bits of the base channel class piecewise, eventually leaving an empty class that can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LocalChannel, the only extant channel, does not have any close() behaviour.
This is part of #3515 channel removal.
Type of change