Remove the opportunity to configure script_dir for LocalChannel #3684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this PR, if the argument defaulted to None, then the DFK would set a script dir based on the workflow rundir. Post this PR, this default behaviour is the only behaviour and the user cannot specify an overriding value. Future PRs will remove channel level script directories entirely. This is part of issues #3515 removing channels,
benclifford
force-pushed
the
benc-3515-no-configurable-script-dir
branch
from
74dc193 to
b7082fd
Compare
khk-globus
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, if the argument defaulted to None, then the DFK would set a script dir based on the workflow rundir.
Post this PR, this default behaviour is the only behaviour and the user cannot specify an overriding value.
Future PRs will remove channel level script directories entirely. This is part of issues #3515 removing channels,
Changed Behaviour
This PR removes a little-used user configuration option.
Type of change