Be explicit about filesystem monitoring radio being ForkProcess #3680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this PR, on Linux, this is already a fork process because of defaults. But this process *must* be a fork process, for the same reason that other explicit ForkProcesses in Parsl must be fork processes: we cannot re-import the the unknown user workflow script again. This PR makes that explicit and consistent with other forked processes. Longer term, multiprocessing-forked processes need to go away throughout Parsl - see issue #2343, but this PR is not for that.
khk-globus
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, on Linux, this is already a fork process because of defaults.
But this process must be a fork process, for the same reason that other explicit ForkProcesses in Parsl must be fork processes: we cannot re-import the the unknown user workflow script again.
This PR makes that explicit and consistent with other forked processes.
Longer term, multiprocessing-forked processes need to go away throughout Parsl - see issue #2343, but this PR is not for that.
Changed Behaviour
This should not change behaviour on Linux. On platforms that are not Linux, nothing is supported and is probably already broken here.
Type of change