-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.13 to CI #3646
Add Python 3.13 to CI #3646
Conversation
This needs a radical pilot upgrade, which doesn't work immediately in my dev environment. If I change to radical pilot and utils 1.83, and run
|
Hi Ben - you would also need to update |
This brings in fixes for a few issues that are fixed on the radical side of things: #3722 - a race condition on task completion #3708 - cleaner shutdown handling as part of #3397 #3646 - Python 3.13 support # Changed Behaviour whatever has changed in radical-pilot # Fixes #3722 ## Type of change - Bug fix
after radical upgrade in #3725, the next block is in parsl-visualize, with a tangle between pandas (which needs upgrading to compile on Python 3.13) ... which loosens the numpy bounds ... which breaks networkx ... and also the pandas sqlalchemy interface has changed (now it cannot take an engine and needs a connection object? https://stackoverflow.com/questions/38332787/pandas-to-sql-to-sqlite-returns-engine-object-has-no-attribute-cursor) |
possibly there should be a monitoring upgrade to sqlalchemy 2 -- I did a port before so that LSST people could use that even though the in-tree dependency spec is for 1.x, and one of the above pandas problems is due to using sqlalchemy 1.x |
networkx is fixed for numpy 2 in b0c380499d97489369d7eabbc116964de84859b9 in the numpy repo
|
This is a piece of PR #3646 to support Python 3.13 networkx 3.2 is the first version to support numpy 2. Later versions do not support Python 3.9.
This is a piece of PR #3646 to support Python 3.13 networkx 3.2 is the first version to support numpy 2. Later versions do not support Python 3.9. # Changed Behaviour This is a package upgrade that behaves the same in my testing ## Type of change - Code maintenance/cleanup
This is part of supporting Python 3.13 (PR #3646), as a prereq to upgrading pandas. # Changed Behaviour Development environments (which have the requirements in `test-requirements.txt` installed) will break and need `pip uninstall sqlalchemy2-stubs` - sqlalchemy packaging does not express a negative/removal requirement against that transitional package. non-parsl user code which happens to use the parsl-installed sqlalchemy might break - for example, see API changes in the test suite in this PR ## Type of change - Code maintenance/cleanup
# Description This is part of supporting Python 3.13 (PR #3646). The previous pandas constraints cannot install on Python 3.13. # Changed Behaviour none ## Type of change - Code maintenance/cleanup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love when PRs get to be this simple. Assuming tests pass, approved. 👏
Type of change