Better closing of SSH channel #3504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is paired with DFK behaviour introduced in PR #3503 which closes channels in the DFK. This PR modifies a test which does not use the DFK to also perform that shutdown. With test parsl/tests/test_providers/test_local_provider.py, this reduces the number of threads remaining at the end of execution from 3 to 2.
benclifford
changed the title
benclifford
added a commit
that referenced
this pull request
Jul 2, 2024
This stops that thread being left still running over the end of the test - which is needed in work in PR #3397 to ensure that no threads are left running at the end of a test. If that shutdown hangs, this test will now hang rather than leave the thread behind. Along with PR #3504, this eliminates any threads left behind after parsl/tests/test_providers/test_local_provider.py
benclifford
added a commit
that referenced
this pull request
Jul 3, 2024
This stops that thread being left still running over the end of the test - which is needed in work in PR #3397 to ensure that no threads are left running at the end of a test. If that shutdown hangs, this test will now hang rather than leave the thread behind. Along with PR #3504, this eliminates any threads left behind after parsl/tests/test_providers/test_local_provider.py
khk-globus
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is paired with DFK behaviour introduced in PR #3503 which closes channels in the DFK.
This PR makes SSHChannel.close (soft) wait until its worker thread is shut down. This is initially driven by the desire for threads to be shut down before test cases end, but more generally is part of a goal of shutting everything down before the relevant close/cleanup operation completes.
"soft" in this sense means that after 30 seconds, a warning will be emitted, rather than hanging longer than that.
This PR modifies a test which does not use the DFK to also perform that shutdown - with parsl/tests/test_providers/test_local_provider.py, this reduces the number of threads remaining at the end of execution from 3 to 2.
Type of change