Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close stdin used to send config to Interchange #3501

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Close stdin used to send config to Interchange #3501

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions parsl/executors/high_throughput/executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,6 +551,7 @@ def _start_local_interchange_process(self) -> None:
logger.debug("Popened interchange process. Writing config object")
stdin.write(config_pickle)
stdin.flush()
stdin.close()
logger.debug("Sent config object. Requesting worker ports")
Comment on lines 553 to 555
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest adding some version of a UT for this. It's not an important detail, per se, but it's also a detail that I can see being easily forgotten/missed in a refactor. Especially from newer contributors.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3397 is a longer term plan to catch all leftover fds and threads

try:
(self.worker_task_port, self.worker_result_port) = self.command_client.run("WORKER_PORTS", timeout_s=120)
Expand Down
Loading