Replace SingleNodeLauncher with SimpleLauncher for MPI Mode #3418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SingleNodeLauncher creates too many workers when running in MPI mode
benclifford
reviewed
May 16, 2024
| @@ -1,4 +1,3 @@ | |||
| import logging | |||
There was a problem hiding this comment.
I have been trying to keep tidyups in separate PRs from functionality changes, with a goal of the changes being on-topic - this stuff is super confusing to debug when it turns out eg. something broke because of a changed import rather than a launcher change.
There was a problem hiding this comment.
I made this into PR #3436
benclifford
approved these changes
May 16, 2024
|
i changed "executor" to "worker pool" in the merge message - another note for #3426 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Corrects a problem in the MPI mode implementation of HTEx. SingleNodeLauncher creates too many workers when running in MPI mode because it launches multiple copies of the executor onto the head node.
We want SimpleLauncher, which (instead) launches a single copy of the executor.
Changed Behaviour
Anything that uses the MPI mode will now create the desired number of workers.
Fixes
No issue, but see discussion in Slack.
Type of change
Choose which options apply, and delete the ones which do not apply.