Set Executor attributes in super class constructor #3361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting these attributes in the constructor makes reasoning about later use less complicated. If an Executor is instantiated these exist. Whether or not they've been set to a non-default value is another question.
khk-globus
force-pushed
the
set_executor_base_sane_default_values
branch
from
9cfae82 to
eabed74
Compare
benclifford
approved these changes
Apr 18, 2024
benclifford
added a commit
that referenced
this pull request
May 15, 2024
These have been initialised in the ParslExecutor base class since #3361
benclifford
added a commit
that referenced
this pull request
May 16, 2024
These have been initialised in the ParslExecutor base class since #3361
benclifford
added a commit
that referenced
this pull request
Jul 11, 2024
Prior to this PR, monitoring hub address and ZMQ port were stored as attributes of the DFK. The address also existed as an attribute on dfk.monitoring, and the ZMQ port was returned by dfk.monitoring.start Afte this PR, those values are not added to the DFK, but instead are accessed via dfk.monitoring. These two attributes are now only set on a new executor when monitoring is enabled, rather than always being intialised by the DFK. Default values now come from the executor __init__ method, which is a more usual style in Python for providing default values. See PR #3361 This is part of ongoing work to introduce more pluggable monitoring network connectivity - see PR #3315
benclifford
added a commit
that referenced
this pull request
Jul 18, 2024
Prior to this PR, monitoring hub address and ZMQ port were stored as attributes of the DFK. The address also existed as an attribute on dfk.monitoring, and the ZMQ port was returned by dfk.monitoring.start Afte this PR, those values are not added to the DFK, but instead are accessed via dfk.monitoring. These two attributes are now only set on a new executor when monitoring is enabled, rather than always being intialised by the DFK. Default values now come from the executor __init__ method, which is a more usual style in Python for providing default values. See PR #3361 This is part of ongoing work to introduce more pluggable monitoring network connectivity - see PR #3315
benclifford
added a commit
that referenced
this pull request
Jul 25, 2024
Prior to this PR, monitoring hub address and ZMQ port were stored as attributes of the DFK. The address also existed as an attribute on dfk.monitoring, and the ZMQ port was returned by dfk.monitoring.start Afte this PR, those values are not added to the DFK, but instead are accessed via dfk.monitoring. These two attributes are now only set on a new executor when monitoring is enabled, rather than always being intialised by the DFK. Default values now come from the executor __init__ method, which is a more usual style in Python for providing default values. See PR #3361 This is part of ongoing work to introduce more pluggable monitoring network connectivity - see PR #3315
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Setting these attributes in the constructor makes reasoning about later use less complicated. If an Executor is instantiated these exist. Whether or not they've been set to a non-default value is another question.
Changed Behaviour
Functionally for users, this should represent no change. These attributes are nominally already set by the rest of Parsl's infrastructure. For developers, this change simply makes reasoning about the state of Executors a little easier.
Type of change