Reduce flake8 max-line-length #3222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benclifford
requested changes
Mar 18, 2024
There was a problem hiding this comment.
This is failing automated tests with this error:
Traceback (most recent call last):
File "/home/runner/work/parsl/parsl/.venv/bin/parsl-visualize", line 8, in <module>
sys.exit(cli_run())
File "/home/runner/work/parsl/parsl/.venv/lib/python3.8/site-packages/parsl/monitoring/visualization/app.py", line 28, in cli_run
from parsl.monitoring.visualization import views
File "/home/runner/work/parsl/parsl/.venv/lib/python3.8/site-packages/parsl/monitoring/visualization/views.py", line 11, in <module>
from parsl.monitoring.visualization.plots.default import (
ImportError: cannot import name 'resource_distribution_plot' from 'parsl.monitoring.visualization.plots.default' (/home/runner/work/parsl/parsl/.venv/lib/python3.8/site-packages/parsl/monitoring/visualization/plots/default/__init__.py)
You should be able to find that error yourself by clicking details on the failing test (red x) in the checks section of this pull request.
That might be because you've changed the meaning of the relevant import statement, rather than just reformatting it.
|
The Outreachy application period is over, so I'm closing your PR - thanks for your participation in Parsl+Outreachy so far! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reduce flake8 max-line-length
Changed Behaviour
No change
Fixes
Fixes # (issue)
Type of change