Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce flake8 max-line-length #3213

Closed
wants to merge 3 commits into from
Closed

Reduce flake8 max-line-length #3213

wants to merge 3 commits into from

Conversation

codinBabe
Copy link

Description

Reduce flake8 max-line-length from 147 to 146, making the code base a bit cleaner.

Changed Behaviour

No changed behaviour

Fixes

Fixes # (3105)

Type of change

Choose which options apply, and delete the ones which do not apply.

  • Code maintenance/cleanup

@benclifford
Copy link
Collaborator

The tests failed - you can look at the details by clicking "Details" in the checks section of this PR. You should see these two errors:

parsl/monitoring/monitoring.py:496: error: Statement is unreachable  [unreachable]
parsl/monitoring/monitoring.py:497: error: Unused "type: ignore" comment  [unused-ignore]

Copy link
Collaborator

@benclifford benclifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(see other comment)

@codinBabe
Copy link
Author

Thank you for the review. I will make corrections as suggested.

@benclifford
Copy link
Collaborator

The Outreachy application period is over, so I'm closing your PR - thanks for your participation in Parsl+Outreachy so far!

@benclifford benclifford closed this Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants